Skip to content

Commit bf3be5c

Browse files
committed
- fix faulty tests
2 parents 27b0620 + 76d0177 commit bf3be5c

File tree

5 files changed

+114
-128
lines changed

5 files changed

+114
-128
lines changed

raveandroid/src/main/java/com/flutterwave/raveandroid/RavePayInitializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ public boolean getIsDisplayFee() {
265265
return displayFee;
266266
}
267267

268-
public void setIsDisplayFee() {
268+
public void setIsDisplayFee(boolean displayFee) {
269269
this.displayFee = displayFee;
270270
}
271271
}

raveandroid/src/main/java/com/flutterwave/raveandroid/ach/AchContract.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.flutterwave.raveandroid.ach;
22

3-
import com.flutterwave.raveandroid.Payload;
43
import com.flutterwave.raveandroid.RavePayInitializer;
54
import com.flutterwave.raveandroid.responses.RequeryResponse;
65

@@ -35,13 +34,11 @@ interface UserActionsListener {
3534

3635
void onPayButtonClicked(RavePayInitializer ravePayInitializer, String amount);
3736

38-
void chargeAccount(Payload payload, String encryptionKey, boolean isDisplayFee);
39-
4037
void verifyRequeryResponse(RequeryResponse response, String responseAsJSONString, RavePayInitializer ravePayInitializer, String flwRef);
4138

4239
void onFeeConfirmed(String authUrl, String flwRef);
4340

44-
void processTransaction(String amount, RavePayInitializer ravePayInitializer);
41+
void processTransaction(String amount, RavePayInitializer ravePayInitializer, boolean isDisplayFee);
4542

4643
void onAttachView(View view);
4744

raveandroid/src/main/java/com/flutterwave/raveandroid/ach/AchFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public void onAmountValidated(String amountToSet, int visibility) {
133133

134134
@Override
135135
public void onValidationSuccessful(String amount) {
136-
presenter.processTransaction(amount, ravePayInitializer);
136+
presenter.processTransaction(amount, ravePayInitializer, ravePayInitializer.getIsDisplayFee());
137137
}
138138

139139
@Override

raveandroid/src/main/java/com/flutterwave/raveandroid/ach/AchPresenter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public class AchPresenter implements AchContract.UserActionsListener {
3030

3131
@Inject
3232
SharedPrefsRequestImpl sharedMgr;
33+
3334
@Inject
3435
AmountValidator amountValidator;
3536
@Inject
@@ -55,11 +56,12 @@ public void init(RavePayInitializer ravePayInitializer) {
5556
if (ravePayInitializer != null) {
5657

5758
boolean isAmountValid = amountValidator.isAmountValid(ravePayInitializer.getAmount());
59+
5860
if (isAmountValid) {
5961
mView.onAmountValidated(String.valueOf(ravePayInitializer.getAmount()), View.GONE);
6062
mView.showRedirectMessage(true);
6163
} else {
62-
mView.onAmountValidated(String.valueOf(ravePayInitializer.getAmount()), View.VISIBLE);
64+
mView.onAmountValidated("", View.VISIBLE);
6365
mView.showRedirectMessage(false);
6466
}
6567
}
@@ -82,7 +84,7 @@ public void onPayButtonClicked(RavePayInitializer ravePayInitializer, String amo
8284
}
8385

8486
@Override
85-
public void processTransaction(String amount, RavePayInitializer ravePayInitializer) {
87+
public void processTransaction(String amount, final RavePayInitializer ravePayInitializer, final boolean isDisplayFee) {
8688

8789
ravePayInitializer.setAmount(Double.parseDouble(amount));
8890
PayloadBuilder builder = new PayloadBuilder();
@@ -109,7 +111,6 @@ public void processTransaction(String amount, RavePayInitializer ravePayInitiali
109111
}
110112

111113

112-
@Override
113114
public void chargeAccount(Payload payload, String encryptionKey, final boolean isDisplayFee) {
114115

115116
String requestBodyAsString = payloadToJsonConverter.convertChargeRequestPayloadToJson(payload);

0 commit comments

Comments
 (0)