ACHPresenter TestCases

	requeryTx_onSuccess_onRequerySuccessfulCalled
	verifyRequeryResponseStatus_transactionUnsuccessful_onPaymentFailedCalled
	verifyRequeryResponseStatus_transactionSuccessful_onPaymentSuccessfulCalled
	onFeeConfirmed_showWebViewCalled
	init_inValidAmount_showRedirectMessageFalse
	onPayButtonClicked_inValidAmount_showAmountError_onValidationSuccessfulCalled
	init_validAmount_showRedirectMessageTrue
	onPayButtonClicked_validAmount_showAmountError_onValidationSuccessfulCalled
	processTransaction_chargeAccountCalled
	chargeAccount_onSuccess_nullChargeResponseReturned_onPaymentErrorCalled_noResponseMessage
	chargeAccount_noDisplayFee_onSuccess_validResponseReturned_showWebViewCalled
	requeryTx_onError_onPaymentFailedCalled
	chargeAccount_onSuccess_inValidResponseReturned_onPaymentErrorCalled_noAuthUrlMessage
	chargeAccount_displayFee_chargeCard_onSuccess_saveFlwRef_validResponseReturned_showFeeCalled

	Added AchPresenterTest and AchPresenter to the TestComponent Class
	Injected SharedPrefsRequestImpl Class

Author: mikelis135

raveandroid/build.gradle

@@ -51,6 +51,7 @@ dependencies {
     testImplementation 'com.google.dagger:dagger:2.17'
     testAnnotationProcessor 'com.google.dagger:dagger-compiler:2.17'
     testImplementation 'org.mockito:mockito-core:2.25.0'
+    testImplementation 'org.mockito:mockito-inline:2.13.0'
 
 
 }

raveandroid/src/main/java/com/flutterwave/raveandroid/ach/AchPresenter.java

@@ -2,9 +2,9 @@
 
 import android.content.Context;
 
+import com.flutterwave.raveandroid.DeviceIdGetter;
 import com.flutterwave.raveandroid.Payload;
 import com.flutterwave.raveandroid.PayloadBuilder;
-import com.flutterwave.raveandroid.R;
 import com.flutterwave.raveandroid.RaveConstants;
 import com.flutterwave.raveandroid.RavePayInitializer;
 import com.flutterwave.raveandroid.TransactionStatusChecker;
@@ -23,7 +23,7 @@
 
 public class AchPresenter implements AchContract.UserActionsListener {
 
-    private Context context;
+    Context context;
     private AchContract.View mView;
 
     @Inject
@@ -35,6 +35,8 @@ public class AchPresenter implements AchContract.UserActionsListener {
     NetworkRequestImpl networkRequest;
     @Inject
     TransactionStatusChecker transactionStatusChecker;
+    @Inject
+    DeviceIdGetter deviceIdGetter;
 
     @Inject
     public AchPresenter(Context context, AchContract.View mView) {
@@ -69,7 +71,7 @@ public void onPayButtonClicked(RavePayInitializer ravePayInitializer, String amo
         if (isAmountValid) {
             mView.onValidationSuccessful(amount);
         } else {
-            mView.showAmountError(context.getResources().getString(R.string.validAmountPrompt));
+            mView.showAmountError(RaveConstants.validAmountPrompt);
         }
 
     }
@@ -85,12 +87,12 @@ public void processTransaction(String amount, RavePayInitializer ravePayInitiali
                 .setEmail(ravePayInitializer.getEmail())
                 .setFirstname(ravePayInitializer.getfName())
                 .setLastname(ravePayInitializer.getlName())
-                .setIP(Utils.getDeviceImei(context))
+                .setIP(deviceIdGetter.getDeviceId())
                 .setTxRef(ravePayInitializer.getTxRef())
                 .setMeta(ravePayInitializer.getMeta())
                 .setPBFPubKey(ravePayInitializer.getPublicKey())
                 .setIsUsBankCharge(ravePayInitializer.isWithAch())
-                .setDevice_fingerprint(Utils.getDeviceImei(context));
+                .setDevice_fingerprint(deviceIdGetter.getDeviceId());
 
         if (ravePayInitializer.getPayment_plan() != null) {
             builder.setPaymentPlan(ravePayInitializer.getPayment_plan());
@@ -139,7 +141,7 @@ public void onSuccess(ChargeResponse response, String responseAsJSONString) {
                         }
                     }
                     else {
-                        mView.onPaymentError(context.getResources().getString(R.string.no_authurl_was_returnedmsg));
+                        mView.onPaymentError(RaveConstants.no_authurl_was_returnedmsg);
                     }
 
                 }

raveandroid/src/main/java/com/flutterwave/raveandroid/data/NetworkRequestImpl.java

@@ -37,12 +37,15 @@ public class NetworkRequestImpl implements DataRequest.NetworkRequest {
 
     Retrofit retrofit;
     ApiService service;
+    Gson gson;
+
     private String errorParsingError = "An error occurred parsing the error response";
 
     @Inject
-    public NetworkRequestImpl(Retrofit retrofit, ApiService service) {
+    public NetworkRequestImpl(Retrofit retrofit, ApiService service, Gson gson) {
         this.retrofit = retrofit;
         this.service = service;
+        this.gson = gson;
     }
 
     public NetworkRequestImpl() {

raveandroid/src/main/java/com/flutterwave/raveandroid/data/SharedPrefsRequestImpl.java

@@ -13,18 +13,16 @@
 import java.util.List;
 
 import javax.inject.Inject;
-import javax.inject.Singleton;
 
 import static com.flutterwave.raveandroid.RaveConstants.RAVEPAY;
 
 /**
  * Created by hamzafetuga on 25/07/2017.
  */
 
-@Singleton
 public class SharedPrefsRequestImpl implements DataRequest.SharedPrefsRequest {
 
-    Context context;
+    public Context context;
     SharedPreferences sharedPreferences;
     SharedPreferences.Editor editor;
     String FLW_REF_KEY = "flw_ref_key";
@@ -81,7 +79,6 @@ public List<SavedCard> getSavedCards(String email) {
         String json = sharedPreferences.getString("SAVED_CARDS" + email, "[]");
 
         try {
-            Gson gson = new Gson();
             Type type = new TypeToken<List<SavedCard>>() {
             }.getType();
             return gson.fromJson(json, type);