Use orchestra testbench

Author: Flynsarmy

composer.json

@@ -18,5 +18,8 @@
             "Flynsarmy\\CsvSeeder\\": "src/"
         }
     },
-    "minimum-stability": "dev"
+    "minimum-stability": "dev",
+    "require-dev": {
+        "orchestra/testbench": "^6.0@dev"
+    }
 }

tests/CsvTest.php

@@ -1,41 +1,43 @@
-<?php
+<?php namespace Flynsarmy\CsvSeeder\Tests;
 
-class CsvTest extends TestCase
+class CsvTest extends \Orchestra\Testbench\TestCase
 {
     /**
-     * @before
+     * Setup the test environment.
      */
-    public function runDatabaseMigrations()
+    protected function setUp(): void
     {
-        // Create our testing DB tables
-        $this->artisan('migrate', [
-            '--path' => 'vendor/flynsarmy/csv-seeder/tests/migrations',
-        ]);
+        parent::setUp();
+
+        $this->loadMigrationsFrom(__DIR__ . '/migrations');
+
+        $this->artisan('migrate');
 
         $this->beforeApplicationDestroyed(function () {
             $this->artisan('migrate:rollback');
         });
     }
 
     /**
-     * Setup the test environment.
+     * Define environment setup.
+     *
+     * @param  \Illuminate\Foundation\Application  $app
      *
      * @return void
      */
-    public function setUp()
+    protected function getEnvironmentSetUp($app)
     {
-        parent::setUp();
-
         // Use an in-memory DB
-        $this->app['config']->set('database.default', 'csvSeederTest');
-        $this->app['config']->set('database.connections.csvSeederTest', [
+        $app['config']->set('database.default', 'csvSeederTest');
+        $app['config']->set('database.connections.csvSeederTest', [
             'driver'   => 'sqlite',
             'database' => ':memory:',
             'prefix'   => '',
         ]);
     }
 
-    public function testBOMIsStripped()
+    /** @test */
+    public function it_strips_BOM()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
 
@@ -53,7 +55,8 @@ public function testBOMIsStripped()
         $this->assertEquals($expected, $actual);
     }
 
-    public function testMappings()
+    /** @test */
+    public function it_maps_correctly()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
         $row = [1, 'ignored', 'first', 'last'];
@@ -103,7 +106,7 @@ public function testMappings()
         $this->assertEquals($expected, $actual);
     }
 
-    public function testCanOpenCSV()
+    public function it_can_open_CSV()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
 
@@ -113,28 +116,29 @@ public function testCanOpenCSV()
         $this->assertInternalType($expected, $actual);
 
         // Test a non-openable CSV
-        $expected = FALSE;
+        $expected = false;
         $actual = $seeder->openCSV(__DIR__.'/csvs/csv_that_does_not_exist.csv');
         $this->assertEquals($expected, $actual);
     }
 
-    public function testImport()
+    /** @test */
+    public function it_imports()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
-        $seeder->table = 'users';
+        $seeder->table = 'tests_users';
         $seeder->filename = __DIR__.'/csvs/users.csv';
         $seeder->hashable = '';
         $seeder->run();
 
         // Make sure the rows imported
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 1,
             'first_name' => 'Abe',
             'last_name' => 'Abeson',
             'email' => 'abe.abeson@foo.com',
             'age' => 50,
         ]);
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 3,
             'first_name' => 'Charly',
             'last_name' => 'Charlyson',
@@ -143,23 +147,24 @@ public function testImport()
         ]);
     }
 
-    public function testIgnoredColumnImport()
+    /** @test */
+    public function it_ignores_columns_on_import()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
-        $seeder->table = 'users';
+        $seeder->table = 'tests_users';
         $seeder->filename = __DIR__.'/csvs/users_with_ignored_column.csv';
         $seeder->hashable = '';
         $seeder->run();
 
         // Make sure the rows imported
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 1,
             'first_name' => 'Abe',
             'last_name' => 'Abeson',
             'email' => 'abe.abeson@foo.com',
             'age' => 50,
         ]);
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 3,
             'first_name' => 'Charly',
             'last_name' => 'Charlyson',
@@ -168,41 +173,43 @@ public function testIgnoredColumnImport()
         ]);
     }
 
-    public function testHash()
+    /** @test */
+    public function it_hashes()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
-        $seeder->table = 'users';
+        $seeder->table = 'tests_users';
         $seeder->filename = __DIR__.'/csvs/users.csv';
 
         // Assert unhashed passwords
         $seeder->hashable = '';
         $seeder->run();
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 1,
             'password' => 'abeabeson',
         ]);
 
         // Reset users table
-        DB::table('users')->truncate();
+        \DB::table('tests_users')->truncate();
 
         // Assert hashed passwords
         $seeder->hashable = 'password';
         $seeder->run();
         // Row 1 should still be in DB...
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 1,
         ]);
         // ... But passwords were hashed
-        $this->missingFromDatabase('users', [
+        $this->assertDatabaseMissing('tests_users', [
             'id' => 1,
             'password' => 'abeabeson',
         ]);
     }
 
-    public function testOffset()
+    /** @test */
+    public function it_offsets()
     {
         $seeder = new \Flynsarmy\CsvSeeder\CsvSeeder;
-        $seeder->table = 'users';
+        $seeder->table = 'tests_users';
         $seeder->filename = __DIR__.'/csvs/users.csv';
         $seeder->hashable = '';
         $seeder->offset_rows = 4;
@@ -214,12 +221,12 @@ public function testOffset()
         $seeder->run();
 
         // Assert offset occurred
-        $this->missingFromDatabase('users', [
+        $this->assertDatabaseMissing('tests_users', [
             'id' => 1,
         ]);
 
         // Assert mapping worked
-        $this->seeInDatabase('users', [
+        $this->assertDatabaseHas('tests_users', [
             'id' => 5,
             'first_name' => 'Echo',
             'last_name' => '',

tests/README.md

@@ -1,7 +1,7 @@
 <?php
 use Illuminate\Database\Migrations\Migration;
 
-class CreateUsersTable extends Migration
+class CreateTestsUsersTable extends Migration
 {
     /**
      * Run the migrations.
@@ -10,7 +10,7 @@ class CreateUsersTable extends Migration
      */
     public function up()
     {
-        Schema::create('users', function ($table) {
+        Schema::create('tests_users', function ($table) {
             $table->increments('id');
             $table->string('first_name')->default('');
             $table->string('last_name')->default('');
@@ -27,6 +27,6 @@ public function up()
      */
     public function down()
     {
-        Schema::drop('users');
+        Schema::drop('tests_users');
     }
 }