Address teamscale warnings

Author: ScottDugas

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpacePathSerializer.java

@@ -55,13 +55,13 @@ public KeySpacePathSerializer(@Nonnull final KeySpacePath root) {
 
     @Nonnull
     public ByteString serialize(@Nonnull DataInKeySpacePath data) {
-        KeySpaceProto.DataInKeySpacePath.Builder builder = KeySpaceProto.DataInKeySpacePath.newBuilder();
         final List<KeySpacePath> dataPath = data.getPath().flatten();
         // two paths are only equal if their parents are equal, so we don't have to validate the whole prefix here
         if (dataPath.size() < root.size() ||
                 !dataPath.get(root.size() - 1).equals(root.get(root.size() - 1))) {
             throw new RecordCoreArgumentException("Data is not contained within root path");
         }
+        KeySpaceProto.DataInKeySpacePath.Builder builder = KeySpaceProto.DataInKeySpacePath.newBuilder();
         for (int i = root.size(); i < dataPath.size(); i++) {
             final KeySpacePath keySpacePath = dataPath.get(i);
             builder.addPath(serialize(keySpacePath));
@@ -138,8 +138,6 @@ private static Object deserializeValue(@Nonnull KeySpaceProto.KeySpacePathEntry
 
     @Nonnull
     private static KeySpaceProto.KeySpacePathEntry serialize(@Nonnull final KeySpacePath keySpacePath) {
-        KeySpaceProto.KeySpacePathEntry.Builder builder = KeySpaceProto.KeySpacePathEntry.newBuilder()
-                .setName(keySpacePath.getDirectoryName());
         final Object value = keySpacePath.getValue();
         final KeySpaceDirectory.KeyType keyType = keySpacePath.getDirectory().getKeyType();
 
@@ -158,6 +156,8 @@ private static KeySpaceProto.KeySpacePathEntry serialize(@Nonnull final KeySpace
             }
         }
 
+        KeySpaceProto.KeySpacePathEntry.Builder builder = KeySpaceProto.KeySpacePathEntry.newBuilder()
+                .setName(keySpacePath.getDirectoryName());
         try {
             switch (keyType) {
                 case NULL:

fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpacePathSerializerTest.java

@@ -140,11 +140,6 @@ void testSerializeAndDeserializeMultiLevelPath() {
         assertArrayEquals(value, deserialized.getValue());
     }
 
-    private static Stream<Arguments> testSerializeDeserializeAllKeyTypes() {
-        return KEY_TYPE_TEST_VALUES.entrySet().stream()
-                .map(entry -> Arguments.of(entry.getKey(), entry.getValue()));
-    }
-
     @Test
     void testKeyTypeTestValuesIncludesAllKeyTypes() {
         // Verify that KEY_TYPE_TEST_VALUES contains all KeyType enum values
@@ -153,6 +148,11 @@ void testKeyTypeTestValuesIncludesAllKeyTypes() {
         assertEquals(allKeyTypes, coveredKeyTypes);
     }
 
+    static Stream<Arguments> testSerializeDeserializeAllKeyTypes() {
+        return KEY_TYPE_TEST_VALUES.entrySet().stream()
+                .map(entry -> Arguments.of(entry.getKey(), entry.getValue()));
+    }
+
     @ParameterizedTest
     @MethodSource
     void testSerializeDeserializeAllKeyTypes(KeyType keyType, Object value) {