Fix PMD warnings of using == and !=

`ANY_VALUE` should use reference equality, but it also doesn't
override .equals so this doesn't really make a difference, but
is less surprising to readers.
The comparison in the logging was unnecessary, the toString for
`ANY_VALUE` is `*any*` which works just as well.

Author: ScottDugas

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/DirectoryLayerDirectory.java

@@ -156,7 +156,7 @@ protected boolean isValueValid(@Nullable Object value) {
         // despite comments saying that the resolved value should be allowed.
         if (value instanceof String) {
             // If this directory has a constant value, check that the provided value matches it
-            return getValue() == KeySpaceDirectory.ANY_VALUE || Objects.equals(getValue(), value);
+            return Objects.equals(getValue(), KeySpaceDirectory.ANY_VALUE) || Objects.equals(getValue(), value);
         }
         return false;
     }

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpaceDirectory.java

@@ -189,7 +189,7 @@ protected void validateValue(@Nullable Object value) {
                     LogMessageKeys.EXPECTED_TYPE, getKeyType(),
                     LogMessageKeys.ACTUAL, value,
                     "actual_type", value == null ? "null" : value.getClass().getName(),
-                    "expected_value", getValue() != KeySpaceDirectory.ANY_VALUE ? getValue() : "any");
+                    "expected_value", getValue());
         }
     }