Skip to content

Improve rule/filter caching mechanism #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FoxxMD opened this issue Sep 11, 2022 · 0 comments
Open

Improve rule/filter caching mechanism #108

FoxxMD opened this issue Sep 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@FoxxMD
Copy link
Owner

FoxxMD commented Sep 11, 2022

The current caching mechanism uses a scoped (per event) Map of results to return early. This is fine but at the same time CM is still generating, and keeping in memory, "duplicate" rule/filters that are never used due to the cached results.

The caching mechanism can be simplified, and rules/filters can be de-duplicated, by combining the two using a memoize promise.

@FoxxMD FoxxMD added the enhancement New feature or request label Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant