remove redundant function declaration (#1241)

* remove redundant function declaration

Remove warning message from "gcc -Wredundant-decls" in
FreeRTOS_TCP_IP.c.

Signed-off-by: Florian La Roche <Florian.LaRoche@gmail.com>

* Add -Wredundant-decls to CI checks

* Update formatting CI check Github runnner to ubuntu-latest

* Revert "Update formatting CI check Github runnner to ubuntu-latest"

This reverts commit 28ff474.

* Fix spell check

* Revert "Revert "Update formatting CI check Github runnner to ubuntu-latest""

This reverts commit 8ff4ccf.

---------

Signed-off-by: Florian La Roche <Florian.LaRoche@gmail.com>
Co-authored-by: tony-josi-aws <tonyjosi@amazon.com>

Author: laroche

.github/.cSpellWords.txt

@@ -1568,6 +1568,7 @@ Wpacked
 Wpedantic
 Wpragma
 wrdata
+Wredundant
 Wreserved
 writen
 Wsign

.github/workflows/ci.yml

@@ -131,7 +131,7 @@ jobs:
           exclude-dirs: source/portable/NetworkInterface/STM32
 
   formatting:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - name: Check formatting

source/FreeRTOS_TCP_IP.c

@@ -87,14 +87,6 @@
     /* coverity[misra_c_2012_rule_8_9_violation] */
     _static FreeRTOS_Socket_t * xSocketToListen = NULL;
 
-    #if ( ipconfigHAS_DEBUG_PRINTF != 0 )
-
-/*
- * For logging and debugging: make a string showing the TCP flags.
- */
-        const char * prvTCPFlagMeaning( UBaseType_t xFlags );
-    #endif /* ipconfigHAS_DEBUG_PRINTF != 0 */
-
     static IPv46_Address_t xGetSourceAddrFromBuffer( const uint8_t * const pucEthernetBuffer );
 
 /*-----------------------------------------------------------*/

test/build-combination/CMakeLists.txt

@@ -111,6 +111,7 @@ target_compile_options(freertos_plus_tcp
     $<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Werror>
     $<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wpedantic>
     $<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wconversion>
+    $<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wredundant-decls>
     $<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wunused-variable>
     $<$<COMPILE_LANG_AND_ID:C,Clang>:-Weverything>