Raise PHPStan's level from 5 to 6 (#573)

Author: dkarlovi

Makefile

@@ -6,7 +6,7 @@ ci: cs-full-check phpstan phpunit-coverage
 lint: cs-full-check phpstan
 
 phpstan:
-	sh -c "${QA_DOCKER_COMMAND} phpstan analyse --configuration phpstan.neon --level 5 ."
+	sh -c "${QA_DOCKER_COMMAND} phpstan analyse --configuration phpstan.neon --level 6 ."
 
 cs:
 	sh -c "${QA_DOCKER_COMMAND} php-cs-fixer fix -vvv --diff"

Tests/Form/Handler/AuthorizeFormHandlerTest.php

@@ -29,29 +29,14 @@
  */
 class AuthorizeFormHandlerTest extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|FormInterface
-     */
     protected $form;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|Request|RequestStack
-     */
     protected $request;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|ParameterBag
-     */
     protected $requestQuery;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|ParameterBag
-     */
     protected $requestRequest;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|ContainerInterface
-     */
     protected $container;
 
     /**
@@ -65,7 +50,6 @@ public function setUp()
             ->disableOriginalConstructor()
             ->getMock()
         ;
-        /** @var \PHPUnit_Framework_MockObject_MockObject&Request $request */
         $request = $this->getMockBuilder(Request::class)
             ->disableOriginalConstructor()
             ->getMock()

phpstan.neon

@@ -13,3 +13,5 @@ parameters:
         # how to avoid excluding these?
         - '#Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface::scalarNode()#'
         - '#Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface::end()#'
+        # expected
+        - '#Parameter \#2 $requestStack of class FOS\OAuthServerBundle\Form\Handler\AuthorizeFormHandler constructor expects Symfony\Component\HttpFoundation\Request|Symfony\Component\HttpFoundation\RequestStack|null, stdClass given.#'