Merge pull request #181 from cjobeili/fix-max-file-size

j0k3r · web-flow · commit 5465f1d3ae96 · 2018-02-05T17:00:16.000+01:00
Fix error 'A non well formed numeric value' on sfValidatorFile
diff --git a/lib/validator/sfValidatorFile.class.php b/lib/validator/sfValidatorFile.class.php
@@ -320,16 +320,17 @@ protected function getMaxFilesize()
       return PHP_INT_MAX;
     }
 
+    $value = strtolower(substr($max, 0, -1));
     switch (strtolower(substr($max, -1)))
     {
       case 'g':
-        $max *= 1024;
+        $value *= 1024;
       case 'm':
-        $max *= 1024;
+        $value *= 1024;
       case 'k':
-        $max *= 1024;
+        $value *= 1024;
     }
 
-    return (integer) $max;
+    return (integer) $value;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -320,16 +320,17 @@ protected function getMaxFilesize()`
`320`	`320`	`return PHP_INT_MAX;`
`321`	`321`	`}`
`322`	`322`
	`323`	`+ $value = strtolower(substr($max, 0, -1));`
`323`	`324`	`switch (strtolower(substr($max, -1)))`
`324`	`325`	`{`
`325`	`326`	`case 'g':`
`326`		`- $max *= 1024;`
	`327`	`+ $value *= 1024;`
`327`	`328`	`case 'm':`
`328`		`- $max *= 1024;`
	`329`	`+ $value *= 1024;`
`329`	`330`	`case 'k':`
`330`		`- $max *= 1024;`
	`331`	`+ $value *= 1024;`
`331`	`332`	`}`
`332`	`333`
`333`		`- return (integer) $max;`
	`334`	`+ return (integer) $value;`
`334`	`335`	`}`
`335`	`336`	`}`