Php Inspections (EA Extended): UTs SCA

Author: kalessil

test/unit/command/sfCommandArgumentTest.php

@@ -63,7 +63,7 @@
 $t->diag('->setDefault()');
 $argument = new sfCommandArgument('foo', sfCommandArgument::OPTIONAL, '', 'default');
 $argument->setDefault(null);
-$t->ok(is_null($argument->getDefault()), '->setDefault() can reset the default value by passing null');
+$t->ok(null === $argument->getDefault(), '->setDefault() can reset the default value by passing null');
 $argument->setDefault('another');
 $t->is($argument->getDefault(), 'another', '->setDefault() changes the default value');
 

test/unit/command/sfCommandOptionTest.php

@@ -84,7 +84,7 @@
 $t->is($option->getDefault(), 'default', '->getDefault() returns the default value');
 
 $option = new sfCommandOption('foo', null, sfCommandOption::PARAMETER_REQUIRED);
-$t->ok(is_null($option->getDefault()), '->getDefault() returns null if no default value is configured');
+$t->ok(null === $option->getDefault(), '->getDefault() returns null if no default value is configured');
 
 $option = new sfCommandOption('foo', null, sfCommandOption::IS_ARRAY);
 $t->is($option->getDefault(), array(), '->getDefault() returns an empty array if option is an array');
@@ -96,7 +96,7 @@
 $t->diag('->setDefault()');
 $option = new sfCommandOption('foo', null, sfCommandOption::PARAMETER_REQUIRED, '', 'default');
 $option->setDefault(null);
-$t->ok(is_null($option->getDefault()), '->setDefault() can reset the default value by passing null');
+$t->ok(null === $option->getDefault(), '->setDefault() can reset the default value by passing null');
 $option->setDefault('another');
 $t->is($option->getDefault(), 'another', '->setDefault() changes the default value');
 

test/unit/request/sfWebRequestTest.php

@@ -137,7 +137,7 @@ public function resetPathInfoArray()
 // ->getRequestFormat() ->setRequestFormat()
 $t->diag('->getRequestFormat() ->setRequestFormat()');
 
-$t->ok(is_null($request->getRequestFormat()), '->getRequestFormat() returns null if the format is not defined in the request');
+$t->ok(null === $request->getRequestFormat(), '->getRequestFormat() returns null if the format is not defined in the request');
 $request->setParameter('sf_format', 'js');
 $t->is($request->getRequestFormat(), 'js', '->getRequestFormat() returns the request format');