Fixing Issue #234

Author: pathumhdes

lib/validator/sfValidatorBoolean.class.php

@@ -33,8 +33,8 @@ class sfValidatorBoolean extends sfValidatorBase
    */
   protected function configure($options = array(), $messages = array())
   {
-    $this->addOption('true_values', array('true', 't', 'yes', 'y', 'on', '1'));
-    $this->addOption('false_values', array('false', 'f', 'no', 'n', 'off', '0'));
+    $this->addOption('true_values', array('true', 't', 'yes', 'y', 'on', '1', 1, true));
+    $this->addOption('false_values', array('false', 'f', 'no', 'n', 'off', '0', 0, false));
 
     $this->setOption('required', false);
     $this->setOption('empty_value', false);
@@ -45,12 +45,12 @@ protected function configure($options = array(), $messages = array())
    */
   protected function doClean($value)
   {
-    if (in_array($value, $this->getOption('true_values')))
+    if (in_array($value, $this->getOption('true_values'), true))
     {
       return true;
     }
 
-    if (in_array($value, $this->getOption('false_values')))
+    if (in_array($value, $this->getOption('false_values'), true))
     {
       return false;
     }

test/unit/validator/sfValidatorBooleanTest.php

@@ -10,7 +10,7 @@
 
 require_once(__DIR__.'/../../bootstrap/unit.php');
 
-$t = new lime_test(17);
+$t = new lime_test(21);
 
 $v = new sfValidatorBoolean();