Fix string transformation to keep BC

Author: GromNaN

lib/form/addon/sfFormObject.class.php

@@ -285,6 +285,6 @@ public function renderFormTag($url, array $attributes = array())
 
   protected function camelize($text)
   {
-    return strtr(ucwords(strtr($text, array('/' => '::', '_' => ' ', '-' => ' ', '.' => '_ '))), array(' ' => ''));
+    return strtr(ucwords(strtr($text, array('/' => ':: ', '_' => ' ', '-' => ' '))), array(' ' => ''));
   }
 }

lib/plugins/sfDoctrinePlugin/lib/form/sfFormFilterDoctrine.class.php

@@ -323,7 +323,7 @@ protected function getFieldName($colName)
 
   protected function camelize($text)
   {
-    return strtr(ucwords(strtr($text, array('/' => '::', '_' => ' ', '-' => ' ', '.' => '_ '))), array(' ' => ''));
+    return strtr(ucwords(strtr($text, array('/' => ':: ', '_' => ' ', '-' => ' '))), array(' ' => ''));
   }
 
   protected function getTable()

lib/util/sfInflector.class.php

@@ -28,7 +28,7 @@ class sfInflector
   public static function camelize($lower_case_and_underscored_word)
   {
 
-    return strtr(ucwords(strtr($lower_case_and_underscored_word, array('/' => '::', '_' => ' ', '-' => ' ', '.' => '_ '))), array(' ' => ''));
+    return strtr(ucwords(strtr($lower_case_and_underscored_word, array('/' => ':: ', '_' => ' ', '-' => ' '))), array(' ' => ''));
   }
 
   /**

lib/util/sfToolkit.class.php

@@ -348,9 +348,14 @@ public static function literalize($value, $quoted = false)
    */
   public static function replaceConstants($value)
   {
-    return is_string($value) ? preg_replace_callback('/%(.+?)%/', function ($v) {
+    if (!is_string($value))
+    {
+      return $value;
+    }
+
+    return preg_replace_callback('/%(.+?)%/', function ($v) {
       return sfConfig::has(strtolower($v[1])) ? sfConfig::get(strtolower($v[1])) : '%'.$v[1].'%';
-    }, $value) : $value;
+    }, $value);
   }
 
   /**

lib/vendor/lime/lime.php

@@ -709,7 +709,7 @@ function ($match) use ($colorizer) {
       $message = preg_replace_callback(
         '/(\->|\:\:)?([a-zA-Z0-9_]+?)\(\)/',
         function ($match) use ($colorizer) {
-          return $colorizer->colorize($match[1].$match[2], 'PARAMETER');
+          return $colorizer->colorize($match[1].$match[2].'()', 'PARAMETER');
         },
         $message
       );