After login into account on localhost cms change the last_ip account column to unsuported core value that lead it to crash

[CraftedRO]

After login into account on localhost cms change the last_ip account column to unsuported core value (::1) that lead it to crash when using .pinfo on a character from that account if account is banned

TrinityCore/TrinityCore#28911

Shauren:
We only support ipv4 addresses in that column (and worldserver only writes ipv4 there)

[Err0r1]

Only ipv4 in 2023..
But it's not a fusion problem
Your interface is bound to 127.0.0.1 and ::1

[CraftedRO]

I tested now and old fusion doesn't change last_ip data upon login into cms.

[Err0r1]

Old fusion never updates the IP in last_ip
Column is only updated if you login into the game

[CraftedRO]

yea and that's the correct behaviour I guess

[Err0r1]

The correct behavior is: when someone logs into the account, last_ip should be updated. that's what the column is for
Or shouldn't it be updated, someone logs into the account via the cms and you can't see it because it's not updated?

It's also not a fusion problem
It's 2023, not 2010
If their core crashes because of a valid IP (yeah, ::1 is valid lol), that's certainly not fusion's fault

[CraftedRO]

well just wanted you to know about it (will probably be more reports about this in the future) but I still think that account > last_ip table shoud be left for ingame logins, the cms if it need shoud have separate table or otherwise valid ipv4 format since there's no other option.

[Err0r1]

::1 is valid
Trinitycore just can't handle it because they don't support ipv6 (in 2023..)

The cms is allowed to update/add stuff in the auth database, but not the column? I don't quite understand that

[CraftedRO]

most likely azerothcore or probably others can't too so if we handle those emulators we should handle them completely as they are now idk

[Shauren]

From my point of view any external applications should play by the rules of the db they are modifying. last_ip is a varchar(15) so even if you wanted to be cool, you can't even shove ipv6 addresses there other than the short localhost one.

Also you should not be mocking the project for not supporting ipv6 when its the 3.3.5.12340 wow client that does not support ipv6

[Err0r1]

What about the master branch? Doesn't it support IPv6?
Where do I make fun of the project?
In 2023, IPv6 is something completely normal and widespread

[Shauren]

Yes, master branch client supports ipv6, master branch does not (yet)

As for ipv6 being widespread? i dont get a v6 address from my isp so not as widespread as you might expect (and no, its not some trash tier connection)

[Err0r1]

Maybe it's a Germany or EU thing
Here many have an IPv6 and only on request you get an ipv4 (some still offer ipv4 by default)

I'll think about how to solve this

[CraftedRO]

ok seems TC fixed invalid ip crash so it is up to you to decide if you still change this for other emulators or no idk

[Racknar0]

The problem is when someone is logged into the game, and logs into the web, the last ip is changed to v6, but one solution is to put a pseudiIP v4 from cloudflare, that's how I solved it

Srry for the English.

[Err0r1]

I will change it soon
Stuff related to CMS stays in CMS