Skip to content

[FEATURE REQUEST]: Add sorting_columns #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alxu-avpt opened this issue Apr 15, 2025 · 1 comment
Open

[FEATURE REQUEST]: Add sorting_columns #517

alxu-avpt opened this issue Apr 15, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alxu-avpt
Copy link

Is your feature request related to a problem? Please describe.

Since #163, upstream arrow supports sorting_columns now apache/arrow@da6dbd4.

Describe the solution you'd like

Add a proxy function, similar to builder.Encoding etc.

Describe alternatives you've considered

No response

Additional context

It's possible for ParquetSharp to check the data sort, but I feel it's not necessary.

@adamreeve adamreeve added the enhancement New feature or request label Apr 15, 2025
@adamreeve
Copy link
Contributor

Hi @alxu-avpt, yes we should add this to ParquetSharp. Is this something you could make a PR to add?

I agree it's not necessary to check the sort order, we should just document that it's up to the user to ensure their sort order is correct.

@adamreeve adamreeve added the good first issue Good for newcomers label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants