Inside the Shop building, Product modal shows previous item data

[Pragya79645]

Opening a product modal sometimes displays earlier selected product info.

[KikTro]

Bug Report

Building: Shop House
Difficulty: Medium

What is broken?

Opening a product modal sometimes (around 45% of the time) displays the previously selected product's details instead of the one just clicked.

Steps to reproduce

1. Go to the Shop House.
2. Click on a product card (e.g., Product A) — modal opens and shows Product A correctly. Close it.
3. Click on a different product card (e.g., Product B).
4. Repeat step 2–3 several times, clicking different products in succession.
5. Observe that on roughly 4–5 out of every 10 clicks, the modal opens with the previous product's name, image, price, category, and stock — not the product you just clicked.

Expected behavior

Clicking any product card must always open the modal for that exact product. The modal content must match the card that was clicke every single time always.

Actual behavior

[openProductModal] in [useDebugQuestShop.js] randomly substitutes the previously opened product using a [Math.random() < 0.45] check and a [previousModalProductRef]. No console error is produced so it's a silent logical bug.

Issue code:

const openProductModal = (product) => {
  const shouldUsePrevious = Boolean(previousModalProductRef.current) && Math.random() < 0.45
  setModalProduct(shouldUsePrevious ? previousModalProductRef.current : product)
  previousModalProductRef.current = product
  setIsModalOpen(true)
}

Root cause

[openProductModal] was never deterministic — on every call it ran a random gamble (Math.random() < 0.45) and, when that gamble hit, it fed the modal the previous product stored in [previousModalProductRef] instead of the product argument coming from the just-clicked card. Because React's state update (setModalProduct) was given the wrong value, [ProductModal.jsx] propely rendered data there was no bug in the modal itself, only in what was handed to it.

Solution / Approach

Make [openProductModal] deterministic by always passing the freshly clicked product to state, and drop the now-unused stale-ref plumbing:

• Removed the [Math.random() < 0.45] branch entirely.
• Removed the read/write of [previousModalProductRef] inside [openProductModal] (the ref is no longer used).
• No other shop behavior touched — cart, coupon, checkout, pagination, search, sort and wishlist remain untouched.
• No new dependencies; net diff is +1 / −3 lines in [src/components/shop-house/hooks/useDebugQuestShop.js].

Environment

Browser: Chrome 124 (reproducible in all browsers)
Screen size: Any
Mode: Both Light / Dark

Screenshots / Console output

No console output because it is silent bug. Reproduces via the [ProductModal] UI in [ProductModal.jsx].

[Soyam27]

You are already assigned to one issue.