-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
0 diffThe changes in this pull request have verified to be zero-diff with the target branch.The changes in this pull request have verified to be zero-diff with the target branch.0 diff structuralStructural changes to repository that are zero-diffStructural changes to repository that are zero-diff
Description
The Problem
The GOCART process library contains functionality that is needed by CARMA and MAM. Therefore we need to move it to its own repository to avoid MAM and CARMA to depend on GOCART.
The Solution
Create a repository named AC_ProcessLibrary (for Atmospheric Composition Process Library with the usual fixings).
- Rename the current
GOCART2G_Process.F90AAerosol_process.F90since it is used my more than G2G. - Later, the CCM group will create a new ReactiveGas_Process.F90 and collect vanilla code used by GMI, perhaps others, in this file.
- Later, the carbon folks may want to include GHG_Process.F90
- Remember that a Process library cannot have any ESMF code, just vanilla fortran. Hopefully this will be self contained, no outside dependence or else it complicate its use at NOAA.
@mathomp4 Can you create the empty repo with the usual fixings? Same people as in GOCART for now.
@jrjoshi1 Once the new repo is in place, can you create a feature branch (starting from develop) where you
- Populate the new AC_ProcessLibrary as above.
- Remove the current process library and link with AC_processLibrary?
- Start with the latest GEOSGCM release, create a feature branch, modify components.yaml to bring the AC_ProcessLibrary and adjust the build of the GCM to include this library. Consult with the SI if you have questions.
- Verify zero-diff and submit a PR to GOCART.
@pcolarco I assume you will populate the ReactiveGas_Process.F90 file.
@mmanyin @viral211 @briardew @patricia-nasa To give you the heads up.
Reactions are currently unavailable
Metadata
Metadata
Labels
0 diffThe changes in this pull request have verified to be zero-diff with the target branch.The changes in this pull request have verified to be zero-diff with the target branch.0 diff structuralStructural changes to repository that are zero-diffStructural changes to repository that are zero-diff