From e6aa3ed0ceec5239ff135cc980943285664e1802 Mon Sep 17 00:00:00 2001
From: sahiljhawar <sahil.jhawar448@gmail.com>
Date: Tue, 11 Nov 2025 11:08:13 +0100
Subject: [PATCH] refactor reprocess_files partially fixes #34

---
 swvo/io/omni/omni_high_res.py | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/swvo/io/omni/omni_high_res.py b/swvo/io/omni/omni_high_res.py
index 357a87a..5d1476b 100644
--- a/swvo/io/omni/omni_high_res.py
+++ b/swvo/io/omni/omni_high_res.py
@@ -94,16 +94,15 @@ def download_and_process(
         temporary_dir = Path("./temp_omni_high_res_wget")
         temporary_dir.mkdir(exist_ok=True, parents=True)
 
-        try:
-            file_paths, time_intervals = self._get_processed_file_list(start_time, end_time, cadence_min)
+        file_paths, time_intervals = self._get_processed_file_list(start_time, end_time, cadence_min)
 
-            for file_path, time_interval in zip(file_paths, time_intervals):
-                if file_path.exists():
-                    if reprocess_files:
-                        file_path.unlink()
-                    else:
-                        continue
+        for file_path, time_interval in zip(file_paths, time_intervals):
+            if file_path.exists() and not reprocess_files:
+                continue
 
+            tmp_path = file_path.with_suffix(file_path.suffix + ".tmp")
+
+            try:
                 data = self._get_data_from_omni(
                     start=time_interval[0],
                     end=time_interval[1],
@@ -113,10 +112,17 @@ def download_and_process(
                 logging.debug("Processing file ...")
 
                 processed_df = self._process_single_year(data)
-                processed_df.to_csv(file_path, index=True, header=True)
-
-        finally:
-            rmtree(temporary_dir, ignore_errors=True)
+                processed_df.to_csv(tmp_path, index=True, header=True)
+                tmp_path.replace(file_path)
+
+            except Exception as e:
+                logging.error(f"Failed to process {file_path}: {e}")
+                if tmp_path.exists():
+                    tmp_path.unlink()
+                    pass
+                continue
+            finally:
+                rmtree(temporary_dir, ignore_errors=True)
 
     def read(
         self,
@@ -361,6 +367,7 @@ def _get_data_from_omni(self, start: datetime, end: datetime, cadence: int = 1)
             raise ValueError(msg)
         logging.debug(f"Fetching data from {self.URL} with payload: {payload}")
         response = requests.post(self.URL, data=payload)
+        response.raise_for_status()
         data = response.text.splitlines()
 
         if data and "Error" in data[0]: