Skip to content

Github Workflow Secrets are not inherit-ed due to Github Restriction #286

@Taskeren

Description

@Taskeren

Talked in Discord: https://discord.com/channels/181078474394566657/603348502637969419/1345471366253510656

Github document said that the secrets are not shared across orgranizations or enterprise.

This will cause the step of publishing to maven repository not working consistently, without any warning.

I recommend to flat the workflow calls when creating the template of this ExampleMod (copy the workflow in the GTNH repo to the artifact zip), so we can keep the functionality for it.
Or, at least have a comment on it, to warn users like me that this will not work, instead of debugging for about 2 hrs.

And there are 2 ways to resolve this problem before there is a patch:

  1. https://github.com/sousuke0422/ProjectE/blob/MC17/.github/workflows/release-tags.yml
    Just simply fork the whole workflow repo, and replace it in the dependant projects.
  2. https://github.com/Roadhog360/Et-Futurum-Requiem/blob/master/.github/workflows/release-tags.yml*
    Or just simply copy the referenced one to the workflow in the project.
    *: copying is working, but the referenced sample is not. You'll need to modify the trigger to make it being invoked.

Also don't forget to set the Maven Repository Workflow Variable, because the workflow don't respect the value set in gradle.properties, as I reported it here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions