From 6244a538d5fd855da64663d52e8c6c19ecef7f11 Mon Sep 17 00:00:00 2001 From: Kurt Kilpela Date: Thu, 30 Jan 2025 11:02:01 -0800 Subject: [PATCH 1/2] 170: Rewrite testFailedAcceptOnAlternateLocalhost as testFailedConnect. Testing a failed connect is really the intention of the test. testFailedAcceptOnAlternateLocalhost failed on macOS since it could not bind to the alternate localhost address. --- .../RsrConnectionSpecificationTestCase.class.st | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/RemoteServiceReplication-Test/RsrConnectionSpecificationTestCase.class.st b/src/RemoteServiceReplication-Test/RsrConnectionSpecificationTestCase.class.st index 9e0a3f9..a5373c7 100644 --- a/src/RemoteServiceReplication-Test/RsrConnectionSpecificationTestCase.class.st +++ b/src/RemoteServiceReplication-Test/RsrConnectionSpecificationTestCase.class.st @@ -260,24 +260,15 @@ RsrConnectionSpecificationTestCase >> testEstablishConnection [ ] { #category : 'running' } -RsrConnectionSpecificationTestCase >> testFailedAcceptOnAlternativeLocalhost [ +RsrConnectionSpecificationTestCase >> testFailedConnect [ - | acceptor initiator semaphore | - acceptor := RsrAcceptConnection - host: self alternativeLocalhost - port: self port. + | initiator | initiator := RsrInitiateConnection host: self localhost port: self port. - semaphore := Semaphore new. - RsrProcessModel - fork: [[semaphore signal. acceptor waitForConnection] on: RsrWaitForConnectionCancelled do: [:ex | ex return]] - named: 'Pending WaitForConnectionCancelled'. - [semaphore wait. self should: [initiator connect] - raise: RsrSocketError] - ensure: [acceptor cancelWaitForConnection] + raise: RsrSocketError ] { #category : 'running' } From d964890786b578e14c9b411f28e5af60f94efa74 Mon Sep 17 00:00:00 2001 From: Kurt Kilpela Date: Thu, 30 Jan 2025 11:10:17 -0800 Subject: [PATCH 2/2] 170: Further increase RsrSocketStressTest time limit due to CI timeout. --- src/RemoteServiceReplication-Test/RsrSocketStressTest.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/RemoteServiceReplication-Test/RsrSocketStressTest.class.st b/src/RemoteServiceReplication-Test/RsrSocketStressTest.class.st index 4bbc294..283c8b0 100644 --- a/src/RemoteServiceReplication-Test/RsrSocketStressTest.class.st +++ b/src/RemoteServiceReplication-Test/RsrSocketStressTest.class.st @@ -9,7 +9,7 @@ Class { RsrSocketStressTest class >> defaultTimeLimit [ "These tests take longer over a Socket" - ^60 seconds + ^120 seconds ] { #category : 'testing' }