Skip to content

dbt: set anonymous usage stats and colors to false via env vars#320

Merged
JuFrei merged 3 commits intomasterfrom
fix/deprecate_dbt_profiles_config
Apr 16, 2026
Merged

dbt: set anonymous usage stats and colors to false via env vars#320
JuFrei merged 3 commits intomasterfrom
fix/deprecate_dbt_profiles_config

Conversation

@JuFrei
Copy link
Copy Markdown
Contributor

@JuFrei JuFrei commented Apr 16, 2026

Summary

  • A previous PR removed the send_anonymous_usage_stats and use_colors configurations from the profiles.yml config block since the configuration is outdated and may clash with newer dbt versions.
  • These settings are now passed as environment variables (DBT_SEND_ANONYMOUS_USAGE_STATS, DBT_USE_COLORS) so dbt still picks them up without relying on the deprecated profiles.yml config section.

@JuFrei JuFrei requested a review from PascalCrow April 16, 2026 08:09
@gemma-claude-assistant
Copy link
Copy Markdown
Contributor

Review: PR #320

This PR sets two dbt environment variables in EWAHDBTOperator.execute():

  • DBT_SEND_ANONYMOUS_USAGE_STATS=False — suppresses dbt telemetry network calls during operator execution. Good practice for a pipeline operator.
  • DBT_USE_COLORS=False — strips ANSI escape codes from dbt log output, keeping Airflow logs clean.

Both changes follow the existing code pattern and have no bugs, security issues, or style violations. Approved.

@gemma-claude-assistant
Copy link
Copy Markdown
Contributor

Claude review cost: $0.0964 · 4 turns · 25s · eu.anthropic.claude-sonnet-4-6

Copy link
Copy Markdown
Contributor

@PascalCrow PascalCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request (blocking): ewah Version bump is missing,

@JuFrei JuFrei requested a review from PascalCrow April 16, 2026 08:25
@gemma-claude-assistant
Copy link
Copy Markdown
Contributor

This PR makes two small quality-of-life improvements to the dbt operator's subprocess environment:

  • Disables dbt anonymous usage stats (DBT_SEND_ANONYMOUS_USAGE_STATS=False) — removes outbound telemetry calls during dbt runs.
  • Disables ANSI color output (DBT_USE_COLORS=False) — keeps Airflow logs clean and easier to parse.

Both variables are set on the local env copy (via os.environ.copy()), so they don't affect the Airflow process itself. Change is correct, safe, and follows repo conventions. VERSION bump to 0.9.28 is appropriate. Approved.

@gemma-claude-assistant
Copy link
Copy Markdown
Contributor

Claude review cost: $0.0967 · 4 turns · 22s · eu.anthropic.claude-sonnet-4-6

Copy link
Copy Markdown
Contributor

@PascalCrow PascalCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JuFrei JuFrei merged commit 53699bf into master Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants