[MB2 feedback] devtools::check() results in 0 errors ✔ | 3 warnings ✖ | 1 note ✖ #1
Description
Nice package!
Checking the package using devtools::check() resulted in 0 errors ✔ | 3 warnings ✖ | 1 note ✖ on my machine:
W checking dependencies in R code (2.3s)
'::' or ':::' import not declared from: ‘scales’
and
N checking R code for possible problems (7.8s)
anim_cont_raw: no visible binding for global variable ‘gdf’
anim_discr_raw: no visible binding for global variable ‘rainbow’
create_bubbles: no visible binding for global variable ‘geometry’
create_bubbles: no visible binding for global variable ‘share’
create_bubbles: no visible binding for global variable ‘new_area’
create_bubbles: no visible global function definition for ‘desc’
create_transition: no visible binding for global variable ‘geometry’
create_transition: no visible binding for global variable ‘id’
create_transition: no visible binding for global variable ‘area’
create_transition: no visible binding for global variable ‘v_plot1’
jaro_winkler_similarity: no visible binding for global variable
‘similarity’
merge_df_df: no visible global function definition for ‘all_of’
merge_gd_df: no visible global function definition for ‘all_of’
outlier_identify: no visible global function definition for ‘st_crs<-’
outlier_identify: no visible binding for global variable ‘area’
outlier_identify: no visible binding for global variable ‘sqrt_area’
outlier_identify: no visible binding for global variable ‘geometry’
outlier_identify: no visible binding for global variable ‘id’
outlier_identify: no visible binding for global variable ‘distance_NW’
outlier_identify: no visible binding for global variable ‘distance_NE’
outlier_identify: no visible binding for global variable ‘distance_SE’
outlier_identify: no visible binding for global variable ‘distance_SW’
outlier_identify: no visible binding for global variable
‘distance_bbox’
outlier_identify: no visible binding for global variable
‘lowest_distance’
outlier_moving: no visible binding for global variable ‘outlier’
outlier_moving: no visible global function definition for ‘st_crs<-’
outlier_moving: no visible binding for global variable ‘xmin’
outlier_moving: no visible binding for global variable ‘xmax’
outlier_moving: no visible global function definition for
‘st_geometry<-’
outlier_restructure: no visible binding for global variable ‘id’
outlier_restructure: no visible binding for global variable ‘geometry’
plot_cont: no visible binding for global variable ‘v_plot1’
plot_discr: no visible binding for global variable ‘rainbow’
plot_discr: no visible global function definition for ‘replace_na’
plot_discr: no visible global function definition for ‘setNames’
plot_discr: no visible binding for global variable ‘v_plot1’
Undefined global functions or variables:
all_of area desc distance_NE distance_NW distance_SE distance_SW
distance_bbox gdf geometry id lowest_distance new_area outlier
rainbow replace_na setNames share similarity sqrt_area st_crs<-
st_geometry<- v_plot1 xmax xmin
Consider adding
importFrom("grDevices", "rainbow")
importFrom("stats", "setNames")
to your NAMESPACE file.
The above can be solved by properly importing all functions from other packages that you use internally. Make sure to declare imports, either using :: or roxygen's importFrom so that they are added to NAMESPACE.
W checking Rd \usage sections ...
Undocumented arguments in documentation object 'find_sim_change'
‘thresh’
Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.
The above can be solved by adding thresh to your roxygen documented arguments.
W checking data for non-ASCII characters ...
Warning: found non-ASCII strings
'Andaluc<c3><ad>a' in object 'spain_gdp'
'Arag<c3><b3>n' in object 'spain_gdp'
'Castilla y Le<c3><b3>n' in object 'spain_gdp'
'Catalu<c3><b1>a' in object 'spain_gdp'
'Regi<c3><b3>n de Murcia' in object 'spain_gdp'
'Pa<c3><ad>s Vasco' in object 'spain_gdp'
'PROJCRS["ETRS89 / UTM zone 30N",
BASEGEOGCRS["ETRS89",
ENSEMBLE["European Terrestrial Reference System 1989 ensemble",
MEMBER["European Terrestrial Reference Frame 1989"],
MEMBER["European Terrestrial Reference Frame 1990"],
MEMBER["European Terrestrial Reference Frame 1991"],
MEMBER["European Terrestrial Reference Frame 1992"],
MEMBER["European Terrestrial Reference Frame 1993"],
MEMBER["European Terrestrial Reference Frame 1994"],
MEMBER["European Terrestrial Reference Frame 1996"],
MEMBER["European Terrestrial Reference Frame 1997"],
MEMBER["European Terrestrial Reference Frame 2000"],
MEMBER["European Terrestrial Reference Frame 2005"],
MEMBER["European Terrestrial Reference Frame 2014"],
ELLIPSOID["GRS 1980",6378137,298.257222101,
LENGTHUNIT["metre",1]],
ENSEMBLEACCURACY[0.1]],
PRIMEM["Greenwich",0,
ANGLEUNIT["degree",0.0174532925199433]],
ID["EPSG",4258]],
CONVERSION["UTM zone 30N",
METHOD["Transverse Mercator",
ID["EPSG",9807]],
PARAMETER["Latitude of natural origin",0,
ANGLEUNIT["degree",0.0174532925199433],
ID["EPSG",8801]],
PARAMETER["Longitude of natural origin",-3,
ANGLEUNIT["degree",0.0174532925199433],
ID["EPSG",8802]],
PARAMETER["Scale factor at natural origin",0.9996,
SCALEUNIT["unity",1],
ID["EPSG",8805]],
PARAMETER["False easting",500000,
LENGTHUNIT["metre",1],
ID["EPSG",8806]],
PARAMETER["False northing",0,
LENGTHUNIT["metre",1],
ID["EPSG",8807]]],
CS[Cartesian,2],
AXIS["(E)",east,
ORDER[1],
LENGTHUNIT["metre",1]],
AXIS["(N)",north,
ORDER[2],
LENGTHUNIT["metre",1]],
USAGE[
SCOPE["Engineering survey, topographic mapping."],
AREA["Europe between 6<c2><b0>W and 0<c2><b0>W: Faroe Islands offshore; Ireland - offshore; Jan Mayen - offshore; Norway including Svalbard - offshore; Spain - onshore and offshore."],
BBOX[35.26,-6,80.49,0.01]],
ID["EPSG",25830]]' in object 'spain_gpkg'
Consider covnerting non-ASCII code, e.g. using stringi::stri_escape_unicode.