Skip to content

Commit 737b20e

Browse files
authored
fix: reject promise if peer connection observer is not found (#2)
* fix: promise reject if peer connection observer is not found * 118.1.2-alpha.1 * fix final values * 118.1.2-alpha.2
1 parent d249142 commit 737b20e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ public void peerConnectionSetConfiguration(ReadableMap configuration, int id) {
966966
public void peerConnectionCreateOffer(int id, ReadableMap options, Promise promise) {
967967
ThreadUtils.runOnExecutor(() -> {
968968
PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
969-
PeerConnection peerConnection = pco.getPeerConnection();
969+
PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();
970970

971971
if (peerConnection == null) {
972972
Log.d(TAG, "peerConnectionCreateOffer() peerConnection is null");
@@ -1128,7 +1128,7 @@ public void onSetFailure(String s) {
11281128
public void peerConnectionSetRemoteDescription(int id, ReadableMap desc, Promise promise) {
11291129
ThreadUtils.runOnExecutor(() -> {
11301130
PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
1131-
PeerConnection peerConnection = pco.getPeerConnection();
1131+
PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();
11321132

11331133
if (peerConnection == null) {
11341134
Log.d(TAG, "peerConnectionSetRemoteDescription() peerConnection is null");

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@stream-io/react-native-webrtc",
3-
"version": "118.1.1",
3+
"version": "118.1.2-alpha.2",
44
"repository": {
55
"type": "git",
66
"url": "git+https://github.com/GetStream/react-native-webrtc.git"

0 commit comments

Comments
 (0)