Skip to content

Commit ac91d0a

Browse files
committed
fix: add missing 124 change
1 parent cf08789 commit ac91d0a

File tree

1 file changed

+7
-25
lines changed

1 file changed

+7
-25
lines changed

ios/RCTWebRTC/WebRTCModule+Transceivers.m

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,7 @@ @implementation WebRTCModule (Transceivers)
1616
__block id params;
1717

1818
dispatch_sync(self.workerQueue, ^{
19-
RTCRtpMediaType mediaType = RTCRtpMediaTypeUnsupported;
20-
if ([kind isEqual:@"audio"]) {
21-
mediaType = RTCRtpMediaTypeAudio;
22-
} else if ([kind isEqual:@"video"]) {
23-
mediaType = RTCRtpMediaTypeVideo;
24-
}
25-
26-
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpSenderCapabilitiesFor:mediaType];
19+
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpSenderCapabilitiesForKind:kind];
2720
params = [SerializeUtils capabilitiesToJSON:capabilities];
2821
});
2922

@@ -34,14 +27,7 @@ @implementation WebRTCModule (Transceivers)
3427
__block id params;
3528

3629
dispatch_sync(self.workerQueue, ^{
37-
RTCRtpMediaType mediaType = RTCRtpMediaTypeUnsupported;
38-
if ([kind isEqual:@"audio"]) {
39-
mediaType = RTCRtpMediaTypeAudio;
40-
} else if ([kind isEqual:@"video"]) {
41-
mediaType = RTCRtpMediaTypeVideo;
42-
}
43-
44-
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpSenderCapabilitiesFor:mediaType];
30+
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpReceiverCapabilitiesForKind:kind];
4531
params = [SerializeUtils capabilitiesToJSON:capabilities];
4632
});
4733

@@ -212,8 +198,9 @@ @implementation WebRTCModule (Transceivers)
212198
// Get the available codecs
213199
RTCRtpTransceiverDirection direction = transceiver.direction;
214200
NSMutableArray *availableCodecs = [NSMutableArray new];
201+
NSString *kind = transceiver.mediaType == RTCRtpMediaTypeAudio ? @"audio" : @"video";
215202
if (direction == RTCRtpTransceiverDirectionSendRecv || direction == RTCRtpTransceiverDirectionSendOnly) {
216-
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpSenderCapabilitiesFor:transceiver.mediaType];
203+
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpSenderCapabilitiesForKind:kind];
217204
for (RTCRtpCodecCapability *codec in capabilities.codecs) {
218205
NSDictionary *codecDict = [SerializeUtils codecCapabilityToJSON:codec];
219206
[availableCodecs addObject:@{
@@ -223,8 +210,7 @@ @implementation WebRTCModule (Transceivers)
223210
}
224211
}
225212
if (direction == RTCRtpTransceiverDirectionSendRecv || direction == RTCRtpTransceiverDirectionRecvOnly) {
226-
RTCRtpCapabilities *capabilities =
227-
[self.peerConnectionFactory rtpReceiverCapabilitiesFor:transceiver.mediaType];
213+
RTCRtpCapabilities *capabilities = [self.peerConnectionFactory rtpReceiverCapabilitiesForKind:kind];
228214
for (RTCRtpCodecCapability *codec in capabilities.codecs) {
229215
NSDictionary *codecDict = [SerializeUtils codecCapabilityToJSON:codec];
230216
[availableCodecs addObject:@{
@@ -248,12 +234,8 @@ @implementation WebRTCModule (Transceivers)
248234
}
249235
}
250236

251-
NSError *error;
252-
[transceiver setCodecPreferences:codecsToSet error:&error];
237+
[transceiver setCodecPreferences:codecsToSet];
253238

254-
if (error) {
255-
RTCLogError(@"transceiverSetCodecPreferences() Could not set preferences: %@", error);
256-
}
257239
return nil;
258240
}
259241

@@ -283,4 +265,4 @@ - (RTCRtpParameters *)updateParametersWithOptions:(NSDictionary *)options params
283265
return params;
284266
}
285267

286-
@end
268+
@end

0 commit comments

Comments
 (0)