Fix avatar upload error handling (go-gitea#35887) (go-gitea#35890)

wxiaoguang · web-flow · commit e5b404ec5384 · 2025-11-07T11:25:34.000+08:00
Backport go-gitea#35887
diff --git a/services/auth/source/ldap/source_authenticate.go b/services/auth/source/ldap/source_authenticate.go
@@ -105,9 +105,7 @@ func (source *Source) Authenticate(ctx context.Context, user *user_model.User, u
 			}
 		}
 		if source.AttributeAvatar != "" {
-			if err := user_service.UploadAvatar(ctx, user, sr.Avatar); err != nil {
-				return user, err
-			}
+			_ = user_service.UploadAvatar(ctx, user, sr.Avatar)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -105,9 +105,7 @@ func (source Source) Authenticate(ctx context.Context, user user_model.User, u`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`	`if source.AttributeAvatar != "" {`
`108`		`- if err := user_service.UploadAvatar(ctx, user, sr.Avatar); err != nil {`
`109`		`- return user, err`
`110`		`- }`
	`108`	`+ _ = user_service.UploadAvatar(ctx, user, sr.Avatar)`
`111`	`109`	`}`
`112`	`110`	`}`
`113`	`111`