Skip to content
This repository was archived by the owner on Aug 18, 2024. It is now read-only.
This repository was archived by the owner on Aug 18, 2024. It is now read-only.

Update Role Change forms to be aware of group & member without using tempstore.private #749

@dipakmdhrm

Description

@dipakmdhrm

Problem/Motivation

Og has two forms (OgAddMultipleRolesForm & OgRemoveMultipleRolesForm) to add/remove group roles for a group memeber.

Both these form extend the OgChangeMultipleRolesFormBase class which stores the group & member data in tempstore.private.

This makes it a little complicated to alter these forms and do any kind of logic that needs to be aware of current group and the member for which the roles are being updated.

Proposed resolution

There are two options:

  1. Pass the group & member data in $form_state
  2. Update the current paths for role add & remove from /group/roles/add & /group/roles/remove to /group/{group}/roles/add/{member} & /group/{group}/roles/remove/{member} respectively. This will allow developers to get the group & member data from path.

I'd actually recommend that we do both.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions