Skip to content

[Feature Request] goroutines for k8s-bench task execution #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zvdy opened this issue May 7, 2025 · 1 comment
Closed

[Feature Request] goroutines for k8s-bench task execution #158

zvdy opened this issue May 7, 2025 · 1 comment

Comments

@zvdy
Copy link
Contributor

zvdy commented May 7, 2025

Feature

Implement a more efficient way to execute and run tasks that is not sequential, relying in goroutines when a TasksDir is set.

  1. Improve the process of benchmarking LLMs and their respective models in a quicker manner.
  2. Implement this in the future in CI/CD before main merging, adding a few github action secrets and spinning up a mock cluster should do the job as far as I know

Hope this makes sense.

Bottlenecks

One thing worth noting is that the "simple" solution which is already implemented executes tasks sequentially, which will take quite some time depending on the hardware and the amount of tasks the folder contains, also based on #145 , I agree It's missing some common troubleshooting/issues scenarios people happen to have while working with k8s that are worth benchmarking against. this will make the time increase even more, currently:

Total Time ~= sum(tasks)

The solution for the "bottleneck" of executing all tasks sequentially would be using goroutines and channels to increase the throughput, where:

Total Time ~= longest individual task time + overhead

I also wondered if an hybrid approach would be best but I leave that open to your recommendations.

Let me know if an hybrid approach allowing configurable concurrency, even down to sequential execution or a fully goroutine approach would be best, I would like to work on implementing this.

@zvdy zvdy closed this as completed May 7, 2025
@zvdy zvdy reopened this May 7, 2025
@zvdy zvdy changed the title [Feature Request] Automate all task execution [Feature Request] goroutines for k8s-bench task execution May 8, 2025
@zvdy zvdy closed this as completed May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant