Test against graphblas 7.3.3 (#57)

* Test against graphblas 7.3.3

* Make flake8 happy

* oops

* I like this better (add newline to end of generated files)

Author: eriknw

.github/workflows/test.yml

@@ -19,7 +19,7 @@ jobs:
         # os: ["ubuntu-latest"]
         # source: ["source"]
         python-version: ["3.8", "3.9", "3.10", "3.11"]
-        graphblas-version: ["7.3.2"]
+        graphblas-version: ["7.3.3"]
     steps:
     - name: Checkout
       uses: actions/checkout@v3

setup.cfg

@@ -6,10 +6,10 @@ max-line-length = 100
 inline-quotes = "
 exclude =
     versioneer.py,
-ignore =
-    E203,   # whitespace before ':'
-    E231,   # Multiple spaces around ","
-    W503,   # line break before binary operator
+extend-ignore =
+    E203,
+# E203 whitespace before ':' (to be compatible with black)
+per-file-ignores = suitesparse_graphblas/io/binary.py:C408
 
 [coverage:run]
 source = suitesparse_graphblas

suitesparse_graphblas/__init__.py

@@ -1,7 +1,7 @@
 from . import _version
 from . import exceptions as ex
 from . import utils
-from ._graphblas import ffi, lib  # noqa
+from ._graphblas import ffi, lib
 
 import struct
 import platform

suitesparse_graphblas/create_headers.py

@@ -824,7 +824,7 @@ def main():
     groups = parse_header(processed_h, skip_complex=False)
     text = create_header_text(groups)
     with open(final_h, "w") as f:
-        f.write("\n".join(text))
+        f.write("\n".join(text) + "\n")
 
     # Create final header file (arm64)
     # Replace all variadic arguments (...) with "char *"
@@ -833,20 +833,20 @@ def main():
     patt = re.compile(r"^(extern GrB_Info .*\(.*)(\.\.\.)(\);)$")
     text = [patt.sub(r"\1char *\3", line) for line in orig_text]
     with open(final_arm64_h, "w") as f:
-        f.write("\n".join(text))
+        f.write("\n".join(text) + "\n")
 
     # Create final header file (no complex)
     print(f"Step 5: parse header file to create {final_no_complex_h}")
     groups_no_complex = parse_header(processed_h, skip_complex=True)
     text = create_header_text(groups_no_complex)
     with open(final_no_complex_h, "w") as f:
-        f.write("\n".join(text))
+        f.write("\n".join(text) + "\n")
 
     # Create source
     print(f"Step 6: create {source_c}")
     text = create_source_text(groups)
     with open(source_c, "w") as f:
-        f.write("\n".join(text))
+        f.write("\n".join(text) + "\n")
 
     # Check defines
     print("Step 7: check #define definitions")

suitesparse_graphblas/source.c

@@ -5,4 +5,4 @@ char *GxB_IMPLEMENTATION_DATE_STR = GxB_IMPLEMENTATION_DATE;
 char *GxB_IMPLEMENTATION_LICENSE_STR = GxB_IMPLEMENTATION_LICENSE;
 char *GxB_IMPLEMENTATION_NAME_STR = GxB_IMPLEMENTATION_NAME;
 char *GxB_SPEC_ABOUT_STR = GxB_SPEC_ABOUT;
-char *GxB_SPEC_DATE_STR = GxB_SPEC_DATE;
+char *GxB_SPEC_DATE_STR = GxB_SPEC_DATE;

suitesparse_graphblas/suitesparse_graphblas.h

@@ -3466,4 +3466,4 @@ extern char *GxB_IMPLEMENTATION_DATE_STR;
 extern char *GxB_IMPLEMENTATION_LICENSE_STR;
 extern char *GxB_IMPLEMENTATION_NAME_STR;
 extern char *GxB_SPEC_ABOUT_STR;
-extern char *GxB_SPEC_DATE_STR;
+extern char *GxB_SPEC_DATE_STR;

suitesparse_graphblas/suitesparse_graphblas_arm64.h

@@ -3466,4 +3466,4 @@ extern char *GxB_IMPLEMENTATION_DATE_STR;
 extern char *GxB_IMPLEMENTATION_LICENSE_STR;
 extern char *GxB_IMPLEMENTATION_NAME_STR;
 extern char *GxB_SPEC_ABOUT_STR;
-extern char *GxB_SPEC_DATE_STR;
+extern char *GxB_SPEC_DATE_STR;

suitesparse_graphblas/suitesparse_graphblas_no_complex.h

@@ -3234,4 +3234,4 @@ extern char *GxB_IMPLEMENTATION_DATE_STR;
 extern char *GxB_IMPLEMENTATION_LICENSE_STR;
 extern char *GxB_IMPLEMENTATION_NAME_STR;
 extern char *GxB_SPEC_ABOUT_STR;
-extern char *GxB_SPEC_DATE_STR;
+extern char *GxB_SPEC_DATE_STR;

suitesparse_graphblas/tests/test_io.py

@@ -24,7 +24,7 @@
 if platform.system() == "Windows":
     pytest.skip("skipping windows-only tests", allow_module_level=True)
 
-from suitesparse_graphblas.io import binary  # noqa isort:skip
+from suitesparse_graphblas.io import binary  # isort:skip
 
 NULL = ffi.NULL
 

suitesparse_graphblas/utils.pxd

@@ -38,4 +38,3 @@ cpdef ndarray claim_buffer_2d(
 )
 
 cpdef unclaim_buffer(ndarray array)
-