Update all frontend npm dependencies except Svelte and Vite (#3120)

* Upgrade node dependencies except Svelte 5 and its peer deps

* Fix lint errors

* Fix previous Rust deps upgrade breakage

* Fix demo artwork

* Allow profiling CI workflow to fail

Author: Keavon

.devcontainer/devcontainer.json

@@ -23,7 +23,6 @@
 				"streetsidesoftware.code-spell-checker",
 				// Helpful
 				"mhutchie.git-graph",
-				"waderyan.gitblame",
 				"qezhu.gitlink",
 				"wmaurer.change-case"
 			]

.github/workflows/comment-profiling-changes.yaml

@@ -1,14 +1,15 @@
 name: Profiling Changes
 
 on:
-  pull_request:
+  pull_request: {}
 
 env:
   CARGO_TERM_COLOR: always
 
 jobs:
   profile:
     runs-on: ubuntu-latest
+    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
         with:
@@ -63,7 +64,7 @@ jobs:
         run: |
           # Compile benchmarks
           cargo bench --bench compile_demo_art_iai -- --save-baseline=master
-          
+
           # Runtime benchmarks
           cargo bench --bench update_executor_iai -- --save-baseline=master
           cargo bench --bench run_once_iai -- --save-baseline=master
@@ -78,25 +79,25 @@ jobs:
         run: |
           # Compile benchmarks
           COMPILE_OUTPUT=$(cargo bench --bench compile_demo_art_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-          
+
           # Runtime benchmarks
           UPDATE_OUTPUT=$(cargo bench --bench update_executor_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
           RUN_ONCE_OUTPUT=$(cargo bench --bench run_once_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
           RUN_CACHED_OUTPUT=$(cargo bench --bench run_cached_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-          
+
           # Store outputs
           echo "COMPILE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
           echo "$COMPILE_OUTPUT" >> $GITHUB_OUTPUT
           echo "EOF" >> $GITHUB_OUTPUT
-          
+
           echo "UPDATE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
           echo "$UPDATE_OUTPUT" >> $GITHUB_OUTPUT
           echo "EOF" >> $GITHUB_OUTPUT
-          
+
           echo "RUN_ONCE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
           echo "$RUN_ONCE_OUTPUT" >> $GITHUB_OUTPUT
           echo "EOF" >> $GITHUB_OUTPUT
-          
+
           echo "RUN_CACHED_OUTPUT<<EOF" >> $GITHUB_OUTPUT
           echo "$RUN_CACHED_OUTPUT" >> $GITHUB_OUTPUT
           echo "EOF" >> $GITHUB_OUTPUT
@@ -135,7 +136,7 @@ jobs:
             const updateOutput = JSON.parse(`${{ steps.benchmark.outputs.UPDATE_OUTPUT }}`);
             const runOnceOutput = JSON.parse(`${{ steps.benchmark.outputs.RUN_ONCE_OUTPUT }}`);
             const runCachedOutput = JSON.parse(`${{ steps.benchmark.outputs.RUN_CACHED_OUTPUT }}`);
-            
+
             let significantChanges = false;
             let commentBody = "";
 

.vscode/extensions.json

@@ -13,7 +13,6 @@
 		"streetsidesoftware.code-spell-checker",
 		// Helpful
 		"mhutchie.git-graph",
-		"waderyan.gitblame",
 		"qezhu.gitlink",
 		"wmaurer.change-case"
 	]

frontend/.eslintrc.cjs

@@ -0,0 +1,125 @@
+import js from "@eslint/js";
+import { defineConfig, globalIgnores } from "eslint/config";
+import * as pluginImport from "eslint-plugin-import";
+import pluginPrettier from "eslint-plugin-prettier";
+import pluginSvelte from "eslint-plugin-svelte";
+import globals from "globals";
+import ts from "typescript-eslint";
+
+export default defineConfig([
+	js.configs.recommended,
+	ts.configs.recommended,
+	pluginImport.flatConfigs.recommended,
+	pluginImport.flatConfigs.typescript,
+	pluginSvelte.configs["flat/recommended"],
+	pluginSvelte.configs["flat/prettier"],
+	globalIgnores([
+		// Ignore generated directories
+		"**/node_modules/",
+		"**/dist/",
+		"**/pkg/",
+		"wasm/pkg/",
+		// Don't ignore JS and TS dotfiles in this folder
+		"!**/.*.js",
+		"!**/.*.ts",
+	]),
+	{
+		plugins: {
+			prettier: pluginPrettier,
+		},
+		settings: {
+			"import/parsers": { "@typescript-eslint/parser": [".ts"] },
+			"import/resolver": { typescript: true, node: true },
+		},
+		languageOptions: {
+			parserOptions: {
+				project: "./tsconfig.json",
+			},
+			globals: {
+				...globals.browser,
+				...globals.node,
+			},
+		},
+		rules: {
+			// Standard ESLint config (for ordinary JS syntax linting)
+			indent: "off",
+			quotes: ["error", "double", { allowTemplateLiterals: true }],
+			camelcase: ["error", { properties: "always" }],
+			"linebreak-style": ["error", "unix"],
+			"eol-last": ["error", "always"],
+			"max-len": ["error", { code: 200, tabWidth: 4, ignorePattern: `d="([\\s\\S]*?)"` }],
+			"prefer-destructuring": "off",
+			"no-console": "warn",
+			"no-debugger": "warn",
+			"no-param-reassign": ["error", { props: false }],
+			"no-bitwise": "off",
+			"no-shadow": "off",
+			"no-use-before-define": "off",
+			"no-restricted-imports": ["error", { patterns: [".*", "!@graphite/*"] }],
+
+			// TypeScript plugin config (for TS-specific linting)
+			"@typescript-eslint/indent": "off",
+			"@typescript-eslint/camelcase": "off",
+			"@typescript-eslint/no-use-before-define": "off",
+			"@typescript-eslint/no-unused-vars": [
+				"error",
+				{
+					args: "all",
+					argsIgnorePattern: "^_",
+					caughtErrors: "all",
+					caughtErrorsIgnorePattern: "^_",
+					destructuredArrayIgnorePattern: "^_",
+					varsIgnorePattern: "^_",
+					ignoreRestSiblings: true,
+				},
+			],
+			"@typescript-eslint/consistent-type-imports": "error",
+			"@typescript-eslint/consistent-type-definitions": ["error", "type"],
+			"@typescript-eslint/consistent-type-assertions": ["error", { assertionStyle: "as", objectLiteralTypeAssertions: "never" }],
+			"@typescript-eslint/consistent-indexed-object-style": ["error", "record"],
+			"@typescript-eslint/consistent-generic-constructors": ["error", "constructor"],
+			"@typescript-eslint/no-restricted-types": ["error", { types: { null: "Use `undefined` instead." } }],
+
+			// Prettier plugin config (for validating and fixing formatting)
+			"prettier/prettier": "error",
+
+			// Svelte plugin config (for validating Svelte-specific syntax)
+			"svelte/no-at-html-tags": "off",
+			"svelte/no-useless-mustaches": "off",
+			"svelte/valid-compile": ["error", { ignoreWarnings: true }],
+			"svelte/require-each-key": "off", // TODO: Remove this rule and fix the places where it's violated
+
+			// Import plugin config (for intelligently validating module import statements)
+			"import/no-unresolved": "error",
+			// `no-duplicates` disabled due to <https://github.com/import-js/eslint-plugin-import/issues/1479#issuecomment-1789527447>. Reenable if that issue gets fixed.
+			"import/no-duplicates": "off",
+			"import/prefer-default-export": "off",
+			"import/no-relative-packages": "error",
+			"import/no-named-as-default-member": "off",
+			"import/order": [
+				"error",
+				{
+					alphabetize: { order: "asc", caseInsensitive: true },
+					pathGroups: [{ pattern: "**/*.svelte", group: "unknown", position: "after" }],
+					"newlines-between": "always-and-inside-groups",
+					warnOnUnassignedImports: true,
+				},
+			],
+		},
+	},
+	{
+		files: ["**/*.svelte"],
+		languageOptions: {
+			// Parse the `<script>` in `.svelte` as TypeScript by adding the following configuration.
+			parserOptions: {
+				projectService: true,
+				parser: ts.parser,
+				extraFileExtensions: [".svelte"],
+			},
+		},
+	},
+	{
+		files: ["**/*.js"],
+		extends: [ts.configs.disableTypeChecked],
+	},
+]);