Sync() can timeout

[GregSutcliffe]

Reported by whodoyouexpect in chat - it's possible for sync to timeout. We should probably allow a timeout parameter, and have better error handling when it's hit.

[GregSutcliffe]

update - this is a server-side timeout, so I'm not sure what we can do other than to cleanly report it to the user

[johrpan]

Where did you find information on that? I don't see anything in the spec or the API documentation. Also, if this is a server side timeout, how do other clients handle this? I don't see how we do anything special here. We are just syncing as expected with no special settings or requirements.

[MTRNord]

Where did you find information on that? I don't see anything in the spec or the API documentation. Also, if this is a server side timeout, how do other clients handle this? I don't see how we do anything special here. We are just syncing as expected with no special settings or requirements.

Normal clients will just retry until they get a response. Synapse will continue compiling the data for the response even if the request times out.

[GregSutcliffe]

Where did you find information on that? I don't see anything in the spec or the API documentation. Also, if this is a server side timeout, how do other clients handle this? I don't see how we do anything special here. We are just syncing as expected with no special settings or requirements.

Via the report from the user in chat. They reported getting 504 errors and I've no reason to doubt it.

Normal clients will just retry until they get a response. Synapse will continue compiling the data for the response even if the request times out.

Thanks @MTRNord - sounds like we need to add retries, I'll se what httr can give us