-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or requestrefactorCode that needs refactoringCode that needs refactoring
Milestone
Description
Currently sensors are created by the plant service on initialization:
Firmware/src/plant/plant_service.cpp
Lines 64 to 67 in 881d03b
| PlantService::PlantService(Scheduler *scheduler) | |
| : Task(CHECK_SENSOR_PERIOD, TASK_FOREVER, scheduler, true) { | |
| this->ambient_temperature_sensor = new AmbientTemperatureSensor(); | |
| this->ambient_humidity_sensor = new AmbientHumiditySensor(); |
This should be changed so sensors can be created and destroyed based on the configuration as it changes. A sensor factory is probably a good design pattern to follow. #5 should probably be completed before this so extra work doesn't occur.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestrefactorCode that needs refactoringCode that needs refactoring