Skip to content

Implement the GlitchFreeDevice workaround extension #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kostyanf14 merged 1 commit into from
Jan 30, 2026
Merged

Implement the GlitchFreeDevice workaround extension #855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/engines/hcktest/extensions/GlitchFreeDevice_NdisPollMode_workaround.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"comments": [
"Workaround for NDISTest 6.5 GlitchFreeDevice test incompatibility with NDIS Poll Mode"
],
"tests_config": [
Comment on lines +2 to +5
Copy link

@gemini-code-assist gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This new JSON file has two critical issues:

  1. Invalid JSON: There is a missing comma between the comments block and the tests_config property, which makes the JSON file unparseable.
  2. Unsupported Property: The Extension model, defined as a Sorbet T::Struct in lib/models/extension.rb, does not have a comments property. When this JSON file is loaded, the application will attempt to initialize an Extension object with an unknown property, which will raise a runtime error and cause a crash.

JSON does not have a standard syntax for comments. This kind of metadata should be included in commit messages or pull request descriptions. Please remove the comments field to fix both issues.

Suggested change
"comments": [
"Workaround for NDISTest 6.5 GlitchFreeDevice test incompatibility with NDIS Poll Mode"
],
"tests_config": [
"tests_config": [

Copy link
Contributor Author

@kostyanf14 kostyanf14 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. Sorbet allows for loading objects from JSON with extra fields

{
"tests": [
"NDISTest 6.5 - \\[2 Machine\\] - GlitchFreeDevice"
],
"pre_test_commands": [
{
"desc": "Disable Poll Mode for NetKVM driver to work around GlitchFreeDevice test issues",
"guest_run": "Set-NetAdapterAdvancedProperty -Name SupportDevice0 -DisplayName 'Ndis Poll Mode' -RegistryValue 0"
}
],
"post_test_commands": [
{
"desc": "Re-enable Poll Mode for NetKVM driver after test completion",
"guest_run": "Set-NetAdapterAdvancedProperty -Name SupportDevice0 -DisplayName 'Ndis Poll Mode' -RegistryValue 1"
}
]
}
]
}
Loading