From e8a88fb846068d79b816deed83f740c188c57005 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Favrie?= <benoit14.favrie@gmail.com>
Date: Thu, 15 May 2025 16:14:49 +0200
Subject: [PATCH] =?UTF-8?q?fix:=20change=20success=20code=20response=20?=
 =?UTF-8?q?=E2=9C=85?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/adapters/api/controller/auth.controller.ts | 3 +--
 src/adapters/api/controller/room.controller.ts | 3 +--
 src/adapters/api/controller/talk.controller.ts | 7 +++++--
 src/adapters/api/guards/roles.guard.ts         | 1 -
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/adapters/api/controller/auth.controller.ts b/src/adapters/api/controller/auth.controller.ts
index 22704fe..9db8a3b 100644
--- a/src/adapters/api/controller/auth.controller.ts
+++ b/src/adapters/api/controller/auth.controller.ts
@@ -1,4 +1,4 @@
-import { Body, Controller, Get, Post, UseGuards } from '@nestjs/common';
+import { Body, Controller, Get, Post } from '@nestjs/common';
 import { CreateUserUseCase } from '../../../core/usecases/create-user.use-case';
 import { LoginUseCase } from '../../../core/usecases/login.use-case';
 import { CreateUserRequest } from '../request/create-user.request';
@@ -6,7 +6,6 @@ import { User } from '../../../core/domain/model/User';
 import { UserMapper } from '../mapper/user.mapper';
 import { LoginMapper } from '../mapper/login.mapper';
 import { LoginResponse } from '../response/create-user.response';
-import { JwtAuthGuard } from '../guards/jwt-auth.guard';
 import { CurrentUser } from '../decorator/current-user.decorator';
 import { ProfileMapper } from '../mapper/profile.mapper';
 import { ProfileRequest } from '../request/profile.request';
diff --git a/src/adapters/api/controller/room.controller.ts b/src/adapters/api/controller/room.controller.ts
index 11a0d38..409c3c7 100644
--- a/src/adapters/api/controller/room.controller.ts
+++ b/src/adapters/api/controller/room.controller.ts
@@ -1,4 +1,4 @@
-import { Body, Controller, Get, Param, Post, UseGuards } from '@nestjs/common';
+import { Body, Controller, Get, Param, Post } from '@nestjs/common';
 import { CreateRoomUseCase } from '../../../core/usecases/create-room.use-case';
 import { CreateRoomRequest } from '../request/create-room.request';
 import { CreateRoomMapper } from '../mapper/create-room.mapper';
@@ -6,7 +6,6 @@ import { GetAllRoomsUseCase } from '../../../core/usecases/get-all-rooms.use-cas
 import { GetRoomByIdUseCase } from '../../../core/usecases/get-room-by-id.use-case';
 import { CreateRoomResponse } from '../response/create-room.response';
 import { GetAllRoomsResponse } from '../response/get-all-rooms.response';
-import { JwtAuthGuard } from '../guards/jwt-auth.guard';
 import {
   ApiBadRequestResponse,
   ApiConflictResponse,
diff --git a/src/adapters/api/controller/talk.controller.ts b/src/adapters/api/controller/talk.controller.ts
index 90c1743..a4d5a9c 100644
--- a/src/adapters/api/controller/talk.controller.ts
+++ b/src/adapters/api/controller/talk.controller.ts
@@ -3,14 +3,13 @@ import {
   Controller,
   Post,
   Param,
-  UseGuards,
   Get,
   Query,
+  HttpCode,
 } from '@nestjs/common';
 import { CreateTalkCreationRequestUseCase } from '../../../core/usecases/create-talk-creation-request.use-case';
 import { ApproveOrRejectTalkUseCase } from '../../../core/usecases/approve-or-reject-talk-use.case';
 import { CreateTalkRequest } from '../request/create-talk.request';
-import { JwtAuthGuard } from '../guards/jwt-auth.guard';
 import {
   ApiBadRequestResponse,
   ApiConflictResponse,
@@ -146,6 +145,9 @@ export class TalkController {
   @ApiNoContentResponse({
     description: 'Talk successfully accepted or rejected',
   })
+  @ApiNoContentResponse({
+    description: 'Talk successfully accepted or rejected',
+  })
   @ApiNotFoundResponse({
     description: 'Talk not found (e.g. invalid talk ID or talk does not exist)',
   })
@@ -159,6 +161,7 @@ export class TalkController {
   @ApiUnauthorizedResponse({
     description: 'Unauthorized access',
   })
+  @HttpCode(204)
   async approveOrRejectTalk(
     @Param('talkId') talkId: string,
     @Body() body: ApproveOrRejectTalkRequest,
diff --git a/src/adapters/api/guards/roles.guard.ts b/src/adapters/api/guards/roles.guard.ts
index 27dee94..8fbfd68 100644
--- a/src/adapters/api/guards/roles.guard.ts
+++ b/src/adapters/api/guards/roles.guard.ts
@@ -9,7 +9,6 @@ import { Reflector } from '@nestjs/core';
 import { Request } from 'express';
 import { UserType } from '../../../core/domain/type/UserType';
 import { ROLES_KEY } from '../decorator/roles.decorator';
-import { log } from 'console';
 
 type AuthenticatedUser = {
   id: string;