Skip to content

fix: change success code response ✅ #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MisterAzix merged 1 commit into from
May 15, 2025
Merged

fix: change success code response ✅ #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/adapters/api/controller/auth.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { Body, Controller, Get, Post, UseGuards } from '@nestjs/common';
import { Body, Controller, Get, Post } from '@nestjs/common';
import { CreateUserUseCase } from '../../../core/usecases/create-user.use-case';
import { LoginUseCase } from '../../../core/usecases/login.use-case';
import { CreateUserRequest } from '../request/create-user.request';
import { User } from '../../../core/domain/model/User';
import { UserMapper } from '../mapper/user.mapper';
import { LoginMapper } from '../mapper/login.mapper';
import { LoginResponse } from '../response/create-user.response';
import { JwtAuthGuard } from '../guards/jwt-auth.guard';
import { CurrentUser } from '../decorator/current-user.decorator';
import { ProfileMapper } from '../mapper/profile.mapper';
import { ProfileRequest } from '../request/profile.request';
Expand Down
3 changes: 1 addition & 2 deletions src/adapters/api/controller/room.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { Body, Controller, Get, Param, Post, UseGuards } from '@nestjs/common';
import { Body, Controller, Get, Param, Post } from '@nestjs/common';
import { CreateRoomUseCase } from '../../../core/usecases/create-room.use-case';
import { CreateRoomRequest } from '../request/create-room.request';
import { CreateRoomMapper } from '../mapper/create-room.mapper';
import { GetAllRoomsUseCase } from '../../../core/usecases/get-all-rooms.use-case';
import { GetRoomByIdUseCase } from '../../../core/usecases/get-room-by-id.use-case';
import { CreateRoomResponse } from '../response/create-room.response';
import { GetAllRoomsResponse } from '../response/get-all-rooms.response';
import { JwtAuthGuard } from '../guards/jwt-auth.guard';
import {
ApiBadRequestResponse,
ApiConflictResponse,
Expand Down
7 changes: 5 additions & 2 deletions src/adapters/api/controller/talk.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@ import {
Controller,
Post,
Param,
UseGuards,
Get,
Query,
HttpCode,
} from '@nestjs/common';
import { CreateTalkCreationRequestUseCase } from '../../../core/usecases/create-talk-creation-request.use-case';
import { ApproveOrRejectTalkUseCase } from '../../../core/usecases/approve-or-reject-talk-use.case';
import { CreateTalkRequest } from '../request/create-talk.request';
import { JwtAuthGuard } from '../guards/jwt-auth.guard';
import {
ApiBadRequestResponse,
ApiConflictResponse,
Expand Down Expand Up @@ -146,6 +145,9 @@ export class TalkController {
@ApiNoContentResponse({
description: 'Talk successfully accepted or rejected',
})
@ApiNoContentResponse({
description: 'Talk successfully accepted or rejected',
})
@ApiNotFoundResponse({
description: 'Talk not found (e.g. invalid talk ID or talk does not exist)',
})
Expand All @@ -159,6 +161,7 @@ export class TalkController {
@ApiUnauthorizedResponse({
description: 'Unauthorized access',
})
@HttpCode(204)
async approveOrRejectTalk(
@Param('talkId') talkId: string,
@Body() body: ApproveOrRejectTalkRequest,
Expand Down
1 change: 0 additions & 1 deletion src/adapters/api/guards/roles.guard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { Reflector } from '@nestjs/core';
import { Request } from 'express';
import { UserType } from '../../../core/domain/type/UserType';
import { ROLES_KEY } from '../decorator/roles.decorator';
import { log } from 'console';

type AuthenticatedUser = {
id: string;
Expand Down