New tiffRead returns different datatypes than old one.

[mjlm]

https://github.com/HarveyLab/helperFunctions/blob/master/tiffRead.m
@Selmaan
The new tiffread with the scanimage tiffreader returns int16, whereas the old tiffRead returned something different (either double or uint16, haven't checked yet). This has the potential to break code that expects the old type.

I'm not sure if the datatype that is returned by the new tiffRead is in some sense the "correct" one and we should change other code to deal with it, or if we should change.

[shinkira]

ScanimageTiffReader called in the new tiffread does not properly read old tiff files (i.e., non-bigtiff files), and returns empty Metadata. I think tiffread should first check whether the loading file is tiff or bigtiff.

[Selmaan]

Shin, when I checked it read (the image data from) those tiff files fine, although it could not handle metadata extraction. Are you reporting the same or something different?

…

On Sun, Mar 12, 2017 at 7:56 AM Shin Kira ***@***.***> wrote: ScanimageTiffReader called in the new tiffread does not properly read old tiff files (i.e., non-bigtiff files), and returns empty Metadata. I think tiffread should first check whether the loading file is tiff or bigtiff. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_HarveyLab_helperFunctions_issues_3-23issuecomment-2D285939690&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=uUPHFvcWtS6cSxHj_4ijCDxs5kHbbd_Py4FER2oE0CY&m=Fuab5dgeTZbODczy2fp9LAvdz0lUaH9PeRYG7ZYxtjU&s=mOQl-Gl9Cs8Ac85zXF6_HDpc12mFvXUtyt55csrukFQ&e=>, or mute the thread <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFLYGtq-2DYMUdi3o3Tby4W5EiAUU64MMUks5rk91lgaJpZM4MZqEQ&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=uUPHFvcWtS6cSxHj_4ijCDxs5kHbbd_Py4FER2oE0CY&m=Fuab5dgeTZbODczy2fp9LAvdz0lUaH9PeRYG7ZYxtjU&s=rnc3EKjwluzJRTYWnxnerdD5TMV_AZcV_ztUYMSnLw8&e=> .