fix: LSDV-4627: App crash with FF for DEV-3391 is on (#1196)

* fix: LSDV-4627: Fix app with FF for DEV-3391 is on

MagicWand model is incompatible with new version of ControlBase tag
and crashes the app. So we can just remove `name` param as it's defined
in base tag.

* Register MagicWand in Registry only with FF on

It's better to keep Registry clean of implementation details.
We already have nice error about unknown tags.

* `setFeatureFlags()` should go before `I.amOnPage`

That's how they dynamicly enable feature flags to test different
combinations.

Author: hlomzik

e2e/tests/image.magic-wand.test.js

@@ -79,12 +79,12 @@ Scenario('Make sure the magic wand works in a variety of scenarios', async funct
     annotations: [annotationEmpty],
   };
 
-  I.amOnPage('/');
-
   LabelStudio.setFeatureFlags({
     'fflag_feat_front_dev_4081_magic_wand_tool': true,
   });
 
+  I.amOnPage('/');
+
   I.executeScript(initLabelStudio, params);
 
   AtImageView.waitForImage();

src/core/Registry.ts

@@ -1,5 +1,3 @@
-import { FF_DEV_4081, isFF } from '../utils/feature-flags';
-
 /**
  * Class for register View
  */
@@ -77,10 +75,6 @@ class _Registry {
   getTool(name: string) {
     const model = this.tools[name];
 
-    if (name === 'magicwand' && !isFF(FF_DEV_4081)) {
-      throw new Error('The magicwand feature flag is not on');
-    }
-
     if (!model) {
       const models = Object.keys(this.tools);
 
@@ -98,10 +92,6 @@ class _Registry {
   getModelByTag(tag: string) {
     const model = this.models[tag];
 
-    if (tag === 'magicwand' && !isFF(FF_DEV_4081)) {
-      throw new Error('magicwand feature flag (fflag_fix_front_dev_3391_interactive_view_all) is not on');
-    }
-
     if (!model) {
       const models = Object.keys(this.models);
 

src/tags/control/MagicWand.js

@@ -6,6 +6,7 @@ import { customTypes } from '../../core/CustomTypes';
 import { AnnotationMixin } from '../../mixins/AnnotationMixin';
 import SeparatedControlMixin from '../../mixins/SeparatedControlMixin';
 import { ToolManagerMixin } from '../../mixins/ToolManagerMixin';
+import { FF_DEV_4081, isFF } from '../../utils/feature-flags';
 
 /**
  * The `Magicwand` tag makes it possible to click in a region of an image a user is doing segmentation
@@ -96,7 +97,6 @@ import { ToolManagerMixin } from '../../mixins/ToolManagerMixin';
  */
 
 const TagAttrs = types.model({
-  name: types.identifier,
   toname: types.maybeNull(types.string),
   opacity: types.optional(customTypes.range(), '0.6'),
   blurradius: types.optional(types.string, '5'),
@@ -132,6 +132,6 @@ const HtxView = () => {
   return null;
 };
 
-Registry.addTag('magicwand', MagicWandModel, HtxView);
+isFF(FF_DEV_4081) && Registry.addTag('magicwand', MagicWandModel, HtxView);
 
 export { HtxView, MagicWandModel };