chore: Improve storybook theming #8912
Open
+168
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8912 +/- ##
===========================================
- Coverage 66.10% 57.74% -8.37%
===========================================
Files 820 561 -259
Lines 64416 40878 -23538
Branches 11041 11040 -1
===========================================
- Hits 42581 23603 -18978
+ Misses 21831 17271 -4560
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly improves the Storybook developer experience by enhancing dark mode support and customizing the theme for the Label Studio project. The main changes include adding a custom dark theme, ensuring consistent dark mode styling across Storybook Docs and UI elements, and updating configuration for better maintainability and static asset handling.
Storybook Theming and Configuration Enhancements:
manager.ts.main.tsto addstaticDirsfor serving static assets (like logos) and refactored the configuration for improved readability and maintainability.Dark Mode and Styling Improvements:
preview.scssto enforce dark mode colors throughout Storybook, including Docs pages, tables, code blocks, form controls, and buttons, using CSS variables and!importantfor consistency. [1] [2]main.tsto avoid prefixing CSS class names for Storybook preview styles, ensuring that Storybook's own UI is not affected by local class name prefixing.Code Quality and Maintenance:
main.ts.