This repository was archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Abstracting some code that is copy pasted a few times. #885
Copy link
Copy link
Open
Labels
Comp: CSMPhaseFound: DevelopmentSev: 4lowest prioritylowest priorityStatus: Openopen for someone to grab and start working onopen for someone to grab and start working onType: New Featuregood first issueGood for newcomers to this open source project.Good for newcomers to this open source project.help wantedExtra attention is neededExtra attention is needed
Description
Summary:
const int32_t TS_BUFF_SIZE(80);
const int32_t TS_USEC_SIZE(120);
is referenced a few times in the code.
At least once in these files:
- 706a79e#diff-d88d02e16217487809207c2d3e92de29
- 706a79e#diff-da219aa0af5de5bca52b703114080dcb
- 706a79e#diff-f67f59868971b74c444f3e8c10b02991
- 706a79e#diff-8dcef61fe00e9a1ddf1b4d02966255c4
Instead of defining the const vars in each file. I suggest we make a daemon def include file. Then include that and use those consts.
Advantage:
- If we have to change the value in the future, then we change it in one spot and all values are updated. VS leaving it this way. If we need to update it, then we might accidentally miss one value.
Is your feature request related to a problem? Please describe.
Not really a problem. But the issue is described above in the advantage section.
Describe alternatives you've considered
We could also even make a "construct timestamp function" which could even be more robust.
Issue Source:
Other Notes:
- This is a good first issue and simple issue that might be included in a 24 or 48 hours sprint.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Comp: CSMPhaseFound: DevelopmentSev: 4lowest prioritylowest priorityStatus: Openopen for someone to grab and start working onopen for someone to grab and start working onType: New Featuregood first issueGood for newcomers to this open source project.Good for newcomers to this open source project.help wantedExtra attention is neededExtra attention is needed