Skip to content

web dashboard: do not expose macro values when getting config details #8590

@rerpha

Description

@rerpha

I'm making this here as it'll span a few different repos.

Currently the web dashboard subscribes to IN:INST:CS:BLOCKSERVER:GET_CURR_CONFIG_DETAILS which it then parses to get the current configurations groups, blocks in those groups, then whether or not the block is visible or not by default. This information isn't available in GROUPS or any other blockserver PV.

The problem with this is there are two keys (iocs and component_iocs) which contain information about IOCs - notably macros. Some of these macros are IP addresses on the ISIS network which we shouldn't expose to the world if we can avoid it.

I think this ticket should use a low-effort method of stripping this data out from the config details, as they aren't used anyway currently. If we need a list of IOCs and whether they're running we can use the databaseServer's PVs.

Acceptance criteria

  • Blockserver is modified to include another PV which the web dashboard uses, which removes iocs and component_iocs
  • any logic to do the above is tested
  • the web dashboard is updated to reflect this change

for the third acceptance criteria we are going to have to patch this change onto instruments. a large number will be getting the latest version in January, but some will not - luckily as the blockserver is just python this is straightforward to do.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions