Fix check in tensor_product_axis for one-based axes (#191)

mtfishman · web-flow · commit d76d6ae5e8a5 · 2025-12-03T17:37:14.000-05:00
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "BlockSparseArrays"
 uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4"
 authors = ["ITensor developers <support@itensor.org> and contributors"]
-version = "0.10.13"
+version = "0.10.14"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
diff --git a/ext/BlockSparseArraysTensorAlgebraExt/BlockSparseArraysTensorAlgebraExt.jl b/ext/BlockSparseArraysTensorAlgebraExt/BlockSparseArraysTensorAlgebraExt.jl
@@ -10,7 +10,7 @@ using TensorAlgebra: TensorAlgebra, BlockReshapeFusion, BlockedTuple, matricize,
 function TensorAlgebra.tensor_product_axis(
         ::BlockReshapeFusion, r1::BlockUnitRange, r2::BlockUnitRange
     )
-    isone(first(r1)) || isone(first(r2)) ||
+    (isone(first(r1)) && isone(first(r2))) ||
         throw(ArgumentError("Only one-based axes are supported"))
     blockaxpairs = Iterators.product(eachblockaxes1(r1), eachblockaxes1(r2))
     blockaxs = vec(splat(tensor_product_axis).(blockaxpairs))

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ using TensorAlgebra: TensorAlgebra, BlockReshapeFusion, BlockedTuple, matricize,`
`10`	`10`	`function TensorAlgebra.tensor_product_axis(`
`11`	`11`	`::BlockReshapeFusion, r1::BlockUnitRange, r2::BlockUnitRange`
`12`	`12`	`)`
`13`		`- isone(first(r1)) \|\| isone(first(r2)) \|\|`
	`13`	`+ (isone(first(r1)) && isone(first(r2))) \|\|`
`14`	`14`	`throw(ArgumentError("Only one-based axes are supported"))`
`15`	`15`	`blockaxpairs = Iterators.product(eachblockaxes1(r1), eachblockaxes1(r2))`
`16`	`16`	`blockaxs = vec(splat(tensor_product_axis).(blockaxpairs))`