Merge pull request #375 from Icinga:fix/eventlog_provider_memory_leak

Fix: EventLog provider memory leak

Author: LordHepipud

doc/31-Changelog.md

@@ -9,9 +9,13 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
 
 # 1.12.0 (tbd)
 
-### Enhancements
+# 1.11.2 (tbd)
+
+### Bugfixes
+
+* [#375](https://github.com/Icinga/icinga-powershell-plugins/pull/375) Fixes a memory leak on the Icinga EventLog provider for fetching Windows EventLog information
 
-# 1.11.1 (tbd)
+# 1.11.1 (2023-11-07)
 
 ### Bugfixes
 

provider/eventlog/Get-IcingaEventLog.psm1

@@ -61,6 +61,8 @@ function Get-IcingaEventLog()
 
     [hashtable]$UserFilter     = @{ };
     [hashtable]$SeverityFilter = @{ };
+    [array]$FilteredEvents     = @();
+    [bool]$MemoryCleared       = $FALSE;
 
     if ($null -ne $IncludeUsername -And $IncludeUsername.Count -ne 0) {
         foreach ($entry in $IncludeUsername) {
@@ -137,7 +139,6 @@ function Get-IcingaEventLog()
     }
 
     if ($UserFilter.Count -ne 0 -Or $SeverityFilter.Count -ne 0 -Or $null -ne $IncludeEventId -Or $null -ne $ExcludeEventId -Or $null -ne $ExcludeUsername -Or $null -ne $ExcludeEntryType -Or $null -ne $ExcludeMessage -Or $null -ne $IncludeMessage -Or $null -ne $IncludeSource -Or $null -ne $ExcludeSource) {
-        $filteredEvents = @();
         foreach ($event in $events) {
 
             if ($event.TimeCreated -lt $EventsAfter) {
@@ -231,10 +232,19 @@ function Get-IcingaEventLog()
                 continue;
             }
 
-            $filteredEvents += $event;
+            $FilteredEvents += $event;
         }
 
-        $events = $filteredEvents;
+        if ($null -ne $events) {
+            if ($null -ne ($events | Get-Member -Name 'Dispose')) {
+                $events.Dispose();
+            }
+
+            $events        = $null;
+            $MemoryCleared = $TRUE;
+        }
+
+        $events = $FilteredEvents;
     }
 
     $groupedEvents = @{
@@ -279,5 +289,14 @@ function Get-IcingaEventLog()
         }
     }
 
+    if ($MemoryCleared -eq $FALSE) {
+        if ($null -ne ($events | Get-Member -Name 'Dispose')) {
+            $events.Dispose();
+        }
+    }
+
+    $events         = $null;
+    $FilteredEvents = $null;
+
     return $groupedEvents;
 }