Fixes PermissionDenied exception messages

Author: LordHepipud

doc/31-Changelog.md

@@ -13,6 +13,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
 
 ## Bugfixes
 
+[#196](https://github.com/Icinga/icinga-powershell-plugins/issues/196) Fixes unhandled PermissionDenied exceptions for `Invoke-IcingaCheckDirectory`, in case required permissions for files and folders were not set
 [#202](https://github.com/Icinga/icinga-powershell-plugins/pull/202) Fixes `\` and `/` which are now removed again for `-Include` and `-Exclude` arrays on `Invoke-IcingaCheckUsedPartitionSpace`.
 
 ## 1.5.0 (2021-06-02)

provider/directory/Icinga_Provider_Directory.psm1

@@ -74,14 +74,26 @@ function Get-IcingaDirectory()
         return @();
     }
 
-    $DirectoryData = Get-ChildItem -Path $Path |
-        Where-Object {
-            foreach ($element in $FileNames) {
-                if ($_.Name -like $element) {
-                    return $_.Name
+    try {
+        $DirectoryData = Get-ChildItem -Path $Path -ErrorAction Stop |
+            Where-Object {
+                foreach ($element in $FileNames) {
+                    if ($_.Name -like $element) {
+                        return $_.Name
+                    }
                 }
             }
-        }
+    }  catch {
+        $ExMsg = $_.Exception.Message;
+        Write-IcingaConsoleNotice $_.CategoryInfo;
+        Exit-IcingaThrowException `
+            -InputString $_.CategoryInfo `
+            -StringPattern 'PermissionDenied' `
+            -ExceptionType 'Input' `
+            -ExceptionThrown $IcingaPluginExceptions.FileSystem.PermissionDenied;
+
+        Exit-IcingaThrowException -ExceptionType 'Input' -CustomMessage 'Filesystem Exception' -ExceptionThrown $ExMsg -Force;
+    }
 
     return $DirectoryData;
 }
@@ -98,7 +110,18 @@ function Get-IcingaDirectoryRecurse()
         return @();
     }
 
-    $DirectoryData = Get-ChildItem -Recurse -Include $FileNames -Path $Path;
+    try {
+        $DirectoryData = Get-ChildItem -Recurse -Include $FileNames -Path $Path -ErrorAction Stop;
+    } catch {
+        $ExMsg = $_.Exception.Message;
+        Exit-IcingaThrowException `
+            -InputString $_.CategoryInfo `
+            -StringPattern 'PermissionDenied' `
+            -ExceptionType 'Input' `
+            -ExceptionThrown $IcingaPluginExceptions.FileSystem.PermissionDenied;
+
+        Exit-IcingaThrowException -ExceptionType 'Input' -CustomMessage 'Filesystem Exception' -ExceptionThrown $ExMsg -Force;
+    }
 
     return $DirectoryData;
 }

provider/enums/IcingaGeneralPlugins_Exceptions.psm1

@@ -4,9 +4,14 @@
     EventLogNoMessageEntries = 'Failed to fetch EventLog information. The argument `-MaxEntries` requires to be greater or equal 1';
 };
 
+[hashtable]$FileSystem = @{
+    PermissionDenied = 'You are not permitted to access the defined path.';
+}
+
 if ($null -eq $IcingaPluginExceptions) {
     [hashtable]$IcingaPluginExceptions = @{
-        Inputs = $Inputs;
+        Inputs     = $Inputs;
+        FileSystem = $FileSystem;
     }
 }