Skip to content

configurators in constants or not? #11

@y0shi

Description

@y0shi

m_elevatorMotor = ElevatorConstants.ELEVATOR_MOTOR;
m_Slot0Configs = ElevatorConstants.createSlot0Configs();
m_elevatorMotor.getConfigurator().apply(m_Slot0Configs);
m_softLimitConfig = ElevatorConstants.createSoftLimitConigs();
m_elevatorMotor.getConfigurator().apply(m_softLimitConfig);
m_motionMagicConfigs = ElevatorConstants.createMotionMagicConfigs();
m_elevatorMotor.getConfigurator().apply(m_motionMagicConfigs);
m_motorConfig = ElevatorConstants.createMotorOutputConfigs();
m_elevatorMotor.getConfigurator().apply(m_motorConfig);

In elevator, we configure motors inside the constants class. In end effector, we don't. We should choose one way and do it consistently everywhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions