-
Notifications
You must be signed in to change notification settings - Fork 1
configurators in constants or not? #11
Copy link
Copy link
Open
Description
Robot-2025/src/main/java/frc/robot/subsystems/Elevator/Elevator.java
Lines 75 to 88 in b7461c4
| m_elevatorMotor = ElevatorConstants.ELEVATOR_MOTOR; | |
| m_Slot0Configs = ElevatorConstants.createSlot0Configs(); | |
| m_elevatorMotor.getConfigurator().apply(m_Slot0Configs); | |
| m_softLimitConfig = ElevatorConstants.createSoftLimitConigs(); | |
| m_elevatorMotor.getConfigurator().apply(m_softLimitConfig); | |
| m_motionMagicConfigs = ElevatorConstants.createMotionMagicConfigs(); | |
| m_elevatorMotor.getConfigurator().apply(m_motionMagicConfigs); | |
| m_motorConfig = ElevatorConstants.createMotorOutputConfigs(); | |
| m_elevatorMotor.getConfigurator().apply(m_motorConfig); | |
In elevator, we configure motors inside the constants class. In end effector, we don't. We should choose one way and do it consistently everywhere.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels