Skip to content

Commit 730f333

Browse files
authored
refactor(input-group): design updates (#1870)
1 parent a676033 commit 730f333

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+449
-331
lines changed

package-lock.json

Lines changed: 61 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@
5656
"@floating-ui/dom": "^1.7.4",
5757
"@lit-labs/virtualizer": "^2.1.1",
5858
"@lit/context": "^1.1.6",
59-
"lit": "^3.3.1",
60-
"igniteui-i18n-core": "0.6.0-alpha.4"
59+
"igniteui-i18n-core": "0.6.0-alpha.4",
60+
"lit": "^3.3.1"
6161
},
6262
"devDependencies": {
6363
"@biomejs/biome": "~2.2.6",
@@ -82,7 +82,7 @@
8282
"husky": "^9.1.7",
8383
"ig-typedoc-theme": "^6.2.3",
8484
"igniteui-i18n-resources": "0.6.0-alpha.4",
85-
"igniteui-theming": "^20.0.0",
85+
"igniteui-theming": "^21.0.2",
8686
"keep-a-changelog": "^2.7.1",
8787
"lint-staged": "^16.2.5",
8888
"lit-analyzer": "^2.0.3",

src/components/combo/themes/combo-header.base.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,15 @@
66
// Needed due to how styles are imported in combo-header.ts.
77
--component-size: var(--ig-size, var(--default-size));
88
--default-size: var(--combo-size) !important;
9+
10+
width: 100%;
11+
white-space: nowrap;
12+
13+
::slotted(*) {
14+
@include ellipsis();
15+
16+
display: block;
17+
width: 100%;
18+
align-items: center;
19+
}
920
}

src/components/combo/themes/combo-item.base.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@
88
--default-size: var(--combo-size) !important;
99

1010
gap: rem(8px);
11+
12+
::slotted(*) {
13+
@include ellipsis();
14+
15+
display: block;
16+
width: 100%;
17+
align-items: center;
18+
}
1119
}
1220

1321
igc-checkbox {

src/components/combo/themes/combo.base.scss

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,22 @@
1515
--component-size: var(--combo-size) !important;
1616
}
1717

18-
> igc-input::part(input) {
19-
text-overflow: ellipsis;
18+
igc-input::part(input) {
19+
@include ellipsis();
20+
2021
cursor: pointer;
2122
}
23+
24+
::part(helper-text) {
25+
@include type-style('caption');
26+
@include line-clamp(2, true, true);
27+
28+
overflow-wrap: anywhere;
29+
}
30+
31+
slot[name='value-missing'] {
32+
@include line-clamp(2, true, true);
33+
}
2234
}
2335

2436
:host(:not([single-select])) {
@@ -29,16 +41,6 @@
2941
}
3042
}
3143

32-
[part='helper-text'] {
33-
line-height: 1;
34-
35-
::slotted([slot='helper-text']) {
36-
@include type-style('caption');
37-
38-
line-height: inherit;
39-
}
40-
}
41-
4244
[part='clear-icon'],
4345
[part='toggle-icon'],
4446
[part~='case-icon'] {

src/components/combo/themes/shared/combo.bootstrap.scss

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ $dropdown-theme: dropdown-theme.$bootstrap;
3232
background: var-get($dropdown-theme, 'background-color');
3333
border-radius: var-get($dropdown-theme, 'border-radius');
3434

35+
igc-input,
36+
igc-input::part(container),
37+
igc-input::part(input) {
38+
height: rem(28px);
39+
}
40+
3541
igc-input::part(container) {
3642
background: transparent;
3743
border-inline-start: 0;
@@ -67,13 +73,16 @@ $dropdown-theme: dropdown-theme.$bootstrap;
6773
[part='search-input'] {
6874
[part~='case-icon'] {
6975
border-block-end: rem(1px) solid color(gray, 400);
76+
border-inline: none;
7077
transition: border 0.15s ease-out;
7178
}
7279

7380
&:focus,
7481
&:focus-within {
82+
border-block-end: rem(2px) solid color(primary, 500);
83+
7584
[part~='case-icon'] {
76-
border-block-end: rem(1px) solid color(primary, 500);
85+
border: none;
7786
}
7887
}
7988
}

src/components/combo/themes/shared/combo.fluent.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ $dropdown-theme: dropdown-theme.$fluent;
1010
--combo-size: var(--component-size);
1111

1212
::part(helper-text) {
13-
@include type-style('caption');
14-
1513
margin-block-start: pad-block(rem(5px));
1614
grid-auto-rows: minmax(rem(18px), auto);
1715
}

src/components/combo/themes/shared/combo.indigo.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ $dropdown-theme: dropdown-theme.$indigo;
1717
}
1818

1919
::part(helper-text) {
20-
@include type-style('caption');
21-
2220
margin-block-start: pad-block(rem(4px));
2321
grid-auto-rows: minmax(rem(15px), auto);
2422
}
@@ -72,7 +70,8 @@ $dropdown-theme: dropdown-theme.$indigo;
7270
}
7371

7472
[part='filter-input'] {
75-
padding: pad-inline(rem(12px));
73+
padding-inline: pad-inline(rem(8px), rem(12px), rem(12px));
74+
padding-block: pad-block(rem(12px));
7675
}
7776

7877
:host(:focus-within) {

src/components/combo/themes/shared/combo.material.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@ $dropdown-theme: dropdown-theme.$material;
1212
--combo-size: var(--component-size);
1313

1414
::part(helper-text) {
15-
@include type-style('caption');
16-
1715
margin-block-start: pad-block(rem(4px));
1816
grid-auto-rows: minmax(rem(18px), auto);
19-
padding-inline: pad-inline(rem(14px), rem(16px), rem(18px));
17+
padding-inline: pad-inline(rem(12px), rem(14px), rem(16px));
2018
}
2119

2220
::slotted([slot='prefix']),
@@ -37,6 +35,12 @@ $dropdown-theme: dropdown-theme.$material;
3735
background: var-get($dropdown-theme, 'background-color');
3836
border-radius: var-get($dropdown-theme, 'border-radius');
3937

38+
igc-input,
39+
igc-input::part(container),
40+
igc-input::part(input) {
41+
height: rem(38px);
42+
}
43+
4044
igc-input::part(container) {
4145
background: transparent;
4246
border-inline-start: 0;

src/components/date-picker/themes/date-picker.base.scss

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,17 @@
2222
border-bottom-left-radius: 0;
2323
border-bottom-right-radius: 0;
2424
}
25+
26+
::part(helper-text) {
27+
@include type-style('caption');
28+
@include line-clamp(2, true, true);
29+
30+
overflow-wrap: anywhere;
31+
}
32+
33+
slot[name='value-missing'] {
34+
@include line-clamp(2, true, true);
35+
}
2536
}
2637

2738
:host([required]) {
@@ -31,7 +42,7 @@
3142
}
3243

3344
[part='label'] {
34-
display: inline-block;
45+
display: block;
3546
white-space: nowrap;
3647
text-overflow: ellipsis;
3748
overflow: hidden;

0 commit comments

Comments
 (0)