Skip to content

Commit fe4296b

Browse files
committed
fix(input-group): review comments
1 parent 5bba8df commit fe4296b

File tree

9 files changed

+189
-155
lines changed

9 files changed

+189
-155
lines changed

src/components/date-picker/themes/shared/date-picker.bootstrap.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ $theme: $bootstrap;
2626
@include type-style('body-2');
2727

2828
grid-auto-rows: minmax(rem(20px), auto);
29+
margin-block-start: pad-block(rem(4px));
2930
}
3031
}
3132

src/components/date-picker/themes/shared/date-picker.fluent.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ $theme: $fluent;
1212

1313
[part='label'] {
1414
@include type-style('subtitle-2');
15+
16+
margin-block-end: pad-block(rem(5px));
1517
}
1618

1719
::part(helper-text) {

src/components/date-picker/themes/shared/date-picker.indigo.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ $input-theme: input-theme.$indigo;
2222

2323
[part~='label'] {
2424
@include type-style('caption');
25+
26+
margin-block-end: rem(4px);
2527
}
2628

2729
::part(helper-text) {

src/components/date-range-picker/themes/shared/date-range-picker.bootstrap.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ $theme: $bootstrap;
1616
@include type-style('body-2');
1717

1818
grid-auto-rows: minmax(rem(20px), auto);
19+
margin-block-start: pad-block(rem(4px));
1920
}
2021
}
2122

src/components/input/themes/shared/input.bootstrap.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ $theme: $bootstrap;
1515
@include type-style('body-2');
1616

1717
grid-auto-rows: minmax(rem(20px), auto);
18+
margin-block-start: pad-block(rem(4px));
1819
}
1920

2021
[part='prefix'] {

src/components/textarea/themes/shared/textarea.bootstrap.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ $theme: $bootstrap;
1313
@include type-style('body-2');
1414

1515
grid-auto-rows: minmax(rem(20px), auto);
16+
margin-block-start: pad-block(rem(4px));
1617
}
1718

1819
::slotted([slot="prefix"]),

stories/combo.stories.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,11 @@ export const Form: Story = {
359359
argTypes: disableStoryControls(metadata),
360360
render: () => {
361361
return html`
362+
<style>
363+
fieldset {
364+
min-width: 0;
365+
}
366+
</style>
362367
<form @submit=${formSubmitHandler}>
363368
<fieldset>
364369
<igc-combo

0 commit comments

Comments
 (0)