IECoreScene Camera : Add depthOfField accessors #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding these allow us to address a longstanding todo in Gaffer that will simplify handling of applying depth of field from the globals to a camera.
|
After chatting, Murray and I are less sure about this. While we think it makes good sense in the Cortex/Gaffer world, there are open questions about interoperability, particulary with USD. USD doesn't have a boolean property to turn depth of field on and off, so what should we do on export? Clobber the fStop if depth of field is off? And on import, should we turn off depth of field if the fStop is zero? It seems unclear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these allow us to address a longstanding todo in Gaffer that will simplify handling of applying depth of field from the globals to a camera.