🐛 fix wrong param type + add missing API defs in typescript def file (#293)

* 🐛 fix wrong param type and add missing API defs in typescript def file

* 🐛 fix enum reproStepsMode.enabled not mapped and causing a crash

* 📝 Update changelog

* 💎 Bump version to 8.3.3

Author: salmamali

CHANGELOG.md

@@ -1,3 +1,8 @@
+## v8.3.3 (2019-05-31)
+
+* Fixes crash caused when calling the setReproStepsMode API with enum value enabled.
+* Fixes wrong typescript definition for the setReportTypes API param.
+
 ## v8.3.2 (2019-05-23)
 
 * Fixes an issue that causes release builds to fail on Windows

index.d.ts

@@ -24,10 +24,13 @@ export namespace BugReporting {
   function setShakingThresholdForiPad(iPadShakingThreshold: number): void;
   function setShakingThresholdForAndroid(androidThreshold: number): void;
   function setExtendedBugReportMode(extendedBugReportMode: extendedBugReportMode): void;
-  function setReportTypes(types: reportType): void;
+  function setReportTypes(types: reportType[]): void;
   function showWithOptions(
     type: reportType,
     options: option[]): void;
+  function show(
+    type: reportType,
+    options: option[]): void;
   enum invocationEvent {
     none,
     shake,
@@ -90,6 +93,7 @@ export namespace Replies {
   function hasChats(callback: (previousChats : boolean) => void): void;
   function show(): void;
   function setOnNewReplyReceivedCallback(onNewReplyReceivedCallback: () => void): void;
+  function setOnNewReplyReceivedHandler(onNewReplyReceivedHandler: () => void): void;
   function getUnreadRepliesCount(messageCountCallback: () => void): void;
   function setInAppNotificationsEnabled(inAppNotificationsEnabled: boolean): void;
   function setInAppNotificationSound(shouldPlaySound: boolean): void;
@@ -104,7 +108,9 @@ export namespace Surveys {
   function getAvailableSurveys(availableSurveysCallback: () => void): void;
   function setAutoShowingEnabled(autoShowingSurveysEnabled: boolean): void;
   function onShowCallback(willShowSurveyHandler: () => void): void;
+  function setOnShowHandler(onShowHandler: () => void): void;
   function onDismissCallback(didDismissSurveyHandler: () => void): void;
+  function setOnDismissHandler(onDismissHandler: () => void): void;
   function showSurvey(surveyToken: string): void;
   function hasRespondedToSurvey(
     surveyToken: string,
@@ -122,6 +128,10 @@ export function startWithToken(
   token: string,
   invocationEvent: invocationEvent[]
   ): void;
+export function start(
+  token: string,
+  invocationEvent: invocationEvent[]
+  ): void;
 export function setUserData(userData: string): void;
 export function setAutoScreenRecordingEnabled(autoScreenRecordingEnabled: boolean): void;
 export function setAutoScreenRecordingMaxDuration(autoScreenRecordingMaxDuration: number): void;
@@ -150,6 +160,10 @@ export function setStringToKey(
   string: string,
   key: strings,
   ): void;
+export function setString(
+  key: strings,
+  string: string,
+  ): void;
 export function setEnabledAttachmentTypes(
   screenshot: boolean,
   extraScreenshot: boolean,
@@ -160,8 +174,13 @@ export function identifyUserWithEmail(
   email: string,
   name: string
   ): void;
+export function identifyUser(
+  email: string,
+  name: string
+  ): void;
 export function logOut(): void;
 export function logUserEventWithName(name: string,  params?: any): void;
+export function logUserEvent(name: string): void;
 export function logVerbose(message: string): void;
 export function logInfo(message: string): void;
 export function logDebug(message: string): void;

index.js

@@ -115,7 +115,7 @@ const InstabugModule = {
   },
 
   /**
-   * @deprecated use {@link CrashReporting.setCrashReportingEnabled}
+   * @deprecated use {@link CrashReporting.setEnabled}
    * Report un-caught exceptions to Instabug dashboard
    * We don't send exceptions from __DEV__, since it's way too noisy!
    */
@@ -819,6 +819,7 @@ const InstabugModule = {
    * @enum {number}
    */
   reproStepsMode: {
+    enabled: Instabug.reproStepsEnabled,
     disabled: Instabug.reproStepsDisabled,
     enabledWithNoScreenshots: Instabug.reproStepsEnabledWithNoScreenshots
   },

ios/RNInstabug/InstabugReactBridge.m

@@ -726,6 +726,7 @@ - (NSDictionary *)constantsToExport
               @"dismissTypeCancel": @(IBGDismissTypeCancel),
               @"dismissTypeAddAtttachment": @(IBGDismissTypeAddAttachment),
 
+              @"reproStepsEnabled": @(IBGUserStepsModeEnable),
               @"reproStepsDisabled": @(IBGUserStepsModeDisable),
               @"reproStepsEnabledWithNoScreenshots": @(IBGUserStepsModeEnabledWithNoScreenshots),
 

ios/RNInstabug/RCTConvert+InstabugEnums.m

@@ -48,6 +48,7 @@ @implementation RCTConvert (InstabugEnums)
                                       }), IBGPromptOptionChat, integerValue)
 
 RCT_ENUM_CONVERTER(IBGUserStepsMode, (@{
+                                        @"reproStepsEnabled": @(IBGUserStepsModeEnable),
                                       @"reproStepsDisabled": @(IBGUserStepsModeDisable),
                                       @"reproStepsEnabledWithNoScreenshots": @(IBGUserStepsModeEnabledWithNoScreenshots)
                                       }), IBGUserStepsModeEnabledWithNoScreenshots, integerValue)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "instabug-reactnative",
-  "version": "8.3.2", 
+  "version": "8.3.3", 
   "description": "React Native plugin for integrating the Instabug SDK",
   "main": "index.js",
   "types": "index.d.ts",