[MOB-12414] Disable Android Sourcemaps Upload with Env Var (#983)

Deprecate instabugUploadEnable gradle property to disable Android Sourcemaps auto upload in favor of INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable.

Author: DavidMina96

.circleci/config.yml

@@ -80,13 +80,15 @@ jobs:
       name: android/android-machine
       tag: '2022.03.1'
     working_directory: ~/project/examples/default
+    environment:
+      INSTABUG_SOURCEMAPS_UPLOAD_DISABLE: true
     steps:
       - advanced-checkout/shallow-checkout
       - node/install-yarn
       - install_node_modules
       - android/run-tests:
           working-directory: android
-          test-command: ./gradlew test -PinstabugUploadEnable=false
+          test-command: ./gradlew test
       - persist_to_workspace:
           root: ~/project/android/build/reports/jacoco/jacocoTestReport
           paths:
@@ -190,6 +192,8 @@ jobs:
       name: android/android-machine
       tag: 2022.03.1
       resource-class: large
+    environment:
+      INSTABUG_SOURCEMAPS_UPLOAD_DISABLE: true
     steps:
       - advanced-checkout/shallow-checkout
       - node/install-yarn

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased](https://github.com/Instabug/Instabug-React-Native/compare/v11.10.0...dev)
 
+### Deprecated
+
+- Deprecate `instabugUploadEnable` gradle property to disable Android sourcemaps auto upload in favor of `INSTABUG_SOURCEMAPS_UPLOAD_DISABLE` env variable ([#983](https://github.com/Instabug/Instabug-React-Native/pull/983)).
+
 ### Fixed
 
 - Fix an issue with unhandled JavaScript crashes being reported as native Android crashes ([#980](https://github.com/Instabug/Instabug-React-Native/pull/980)).

README.md

@@ -72,13 +72,7 @@ For your app crashes to show up with a fully symbolicated stack trace, we will a
 If your app token is defined as a constant, you can set an environment variable `INSTABUG_APP_TOKEN` to be used instead.
 We also automatically read your `versionName` and `versionCode` to upload your sourcemap file. alternatively, can also set the environment variables `INSTABUG_APP_VERSION_NAME` and `INSTABUG_APP_VERSION_CODE` to be used instead.
 
-To disable the automatic upload in android, you can set the following property your build.gradle:
-
-```dart
-ext {
-    instabugUploadEnable = false;
-}
-```
+To disable the automatic upload, you can set the environment variable `INSTABUG_SOURCEMAPS_UPLOAD_DISABLE` to TRUE.
 
 ## Network Logging
 

android/sourcemaps.gradle

@@ -14,9 +14,7 @@ gradle.projectsEvaluated {
 task uploadSourcemaps() {
     group 'instabug'
     description 'Uploads sourcemaps file to Instabug server'
-    enabled rootProject.hasProperty('instabugUploadEnable')
-            ? new Boolean(rootProject.property('instabugUploadEnable'))
-            : true
+    enabled = isUploadSourcemapsEnabled()
 
     doLast {
         try {
@@ -59,6 +57,19 @@ task uploadSourcemaps() {
     }
 }
 
+boolean isUploadSourcemapsEnabled() {
+    def envValue = System.getenv('INSTABUG_SOURCEMAPS_UPLOAD_DISABLE')?.toBoolean()
+    def defaultValue = true
+       
+    if (rootProject.hasProperty('instabugUploadEnable')) {
+        project.logger.warn "The property instabugUploadEnable is deprecated and will be removed in an upcoming version. \n" +
+        "You can use INSTABUG_SOURCEMAPS_UPLOAD_DISABLE environment variable instead."
+        defaultValue = rootProject.property('instabugUploadEnable')
+    }
+
+    return (envValue != null) ? !envValue : defaultValue
+}
+
 String resolveVar(String name, String envKey, String defaultValue) {
     def env = System.getenv()
     def envValue = env.get(envKey)

examples/default/.detoxrc.json

@@ -22,7 +22,7 @@
     },
     "android.emu.release": {
       "binaryPath": "android/app/build/outputs/apk/release/app-release.apk",
-      "build": "cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release -PinstabugUploadEnable=false && cd ..",
+      "build": "cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd ..",
       "type": "android.emulator",
       "name": "Nexus_6P_API_27"
     }