Add tests

Author: antonwolfy

dpnp/backend/extensions/vm/erf_funcs.cpp

@@ -193,6 +193,6 @@ void init_erf_funcs(py::module_ m)
         m, "_erfcx",
         "Call `erfcx` function from OneMKL VM library to compute the scaled "
         "complementary error function value of vector elements",
-        impl::erfc_contig_dispatch_vector);
+        impl::erfcx_contig_dispatch_vector);
 }
 } // namespace dpnp::extensions::vm

dpnp/tests/test_special.py

@@ -14,7 +14,7 @@
 
 
 @with_requires("scipy")
-@pytest.mark.parametrize("func", ["erf", "erfc"])
+@pytest.mark.parametrize("func", ["erf", "erfc", "erfcx"])
 class TestCommon:
     @pytest.mark.parametrize(
         "dt", get_all_dtypes(no_none=True, no_float16=False, no_complex=True)
@@ -65,19 +65,31 @@ def test_complex(self, func, dt):
 
 class TestConsistency:
 
-    @pytest.mark.filterwarnings("ignore::RuntimeWarning")
-    def test_erfc(self):
+    def _check_variant_func(self, func, other_func, rtol, atol=0):
         # TODO: replace with dpnp.random.RandomState, once pareto is added
         rng = numpy.random.RandomState(1234)
         n = 10000
         a = rng.pareto(0.02, n) * (2 * rng.randint(0, 2, n) - 1)
         a = dpnp.array(a)
+        a = a[::-1]
 
-        res = 1 - dpnp.scipy.special.erf(a)
+        res = other_func(a)
         mask = dpnp.isfinite(res)
         a = a[mask]
 
-        tol = 8 * dpnp.finfo(a).resolution
-        assert dpnp.allclose(
-            dpnp.scipy.special.erfc(a), res[mask], rtol=tol, atol=tol
+        assert dpnp.allclose(func(a), res[mask], rtol=rtol, atol=atol)
+
+    def test_erfc(self):
+        self._check_variant_func(
+            dpnp.special.erfc,
+            lambda z: 1 - dpnp.special.erf(z),
+            rtol=1e-12,
+            atol=1e-14,
+        )
+
+    def test_erfcx(self):
+        self._check_variant_func(
+            dpnp.special.erfcx,
+            lambda z: dpnp.exp(z * z) * dpnp.special.erfc(z),
+            rtol=1e-12,
         )

dpnp/tests/test_strides.py

@@ -167,7 +167,7 @@ def test_reduce_hypot(dtype, stride):
 
 
 @with_requires("scipy")
-@pytest.mark.parametrize("func", ["erf", "erfc"])
+@pytest.mark.parametrize("func", ["erf", "erfc", "erfcx"])
 @pytest.mark.parametrize("stride", [2, -1, -3])
 def test_erf_funcs(func, stride):
     import scipy.special

dpnp/tests/test_sycl_queue.py

@@ -1488,7 +1488,7 @@ def test_interp(device, left, right, period):
     assert_sycl_queue_equal(result.sycl_queue, x.sycl_queue)
 
 
-@pytest.mark.parametrize("func", ["erf", "erfc"])
+@pytest.mark.parametrize("func", ["erf", "erfc", "erfcx"])
 @pytest.mark.parametrize("device", valid_dev, ids=dev_ids)
 def test_erf_funcs(func, device):
     x = dpnp.linspace(-3, 3, num=5, device=device)

dpnp/tests/test_usm_type.py

@@ -1296,7 +1296,7 @@ def test_choose(usm_type_x, usm_type_ind):
     assert z.usm_type == du.get_coerced_usm_type([usm_type_x, usm_type_ind])
 
 
-@pytest.mark.parametrize("func", ["erf", "erfc"])
+@pytest.mark.parametrize("func", ["erf", "erfc", "erfcx"])
 @pytest.mark.parametrize("usm_type", list_of_usm_types)
 def test_erf_funcs(func, usm_type):
     x = dpnp.linspace(-3, 3, num=5, usm_type=usm_type)

dpnp/tests/third_party/cupyx/scipy_tests/special_tests/test_erf.py

@@ -27,7 +27,6 @@ def test_erf(self):
     def test_erfc(self):
         self.check_unary("erfc")
 
-    @pytest.mark.skip("erfcx() is not supported yet")
     @testing.with_requires("scipy>=1.16.0")
     def test_erfcx(self):
         self.check_unary("erfcx")