From 12615151688d03e4bd6074ee3b11b50aa61d03ad Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 1 Oct 2024 10:44:58 +0200 Subject: [PATCH 1/7] Draft: Run the pynntp tests in the build GitHub Action Based on https://github.com/greenbender/inn-docker/actions running these pytests should add ~30 seconds but give contributors rapid visibility to breakage with the Python client. --- .github/workflows/build.yaml | 74 ++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c1b87b25e..0d601f64a 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -13,9 +13,83 @@ jobs: C_TAP_VERBOSE: 1 steps: + - run: exit 1 # TODO(cclauss): Remove this line!!! - name: checkout uses: actions/checkout@v4 - name: install run: sudo -E ci/install - name: test run: ci/test + + pynntp_tests: + runs-on: ubuntu-latest + + env: + AUTHOR_TESTING: 1 + C_TAP_VERBOSE: 1 + + steps: + - run: env + - uses: actions/checkout@v4 + - run: sudo -E ci/install + - run: ./autogen + - run: ./configure CC="${COMPILER:-gcc}" --prefix=$RUNNER_WORKSPACE/inn-install + --with-canlock --with-news-user=news --with-news-group=news --with-openssl + --with-perl --with-python --with-sasl --with-zlib + - run: make + - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db + - run: touch $RUNNER_WORKSPACE/inn-install/db/history + - run: echo -e "local.general 1726983313 usenet\nlocal.test 1726983317 usenet" > $RUNNER_WORKSPACE/inn-install/db/active.times + - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install + - run: sudo INN_HOSTNAME=inn.github-action make install + # This fails on: + # > touch /home/runner/work/inn/inn-install/db/history + # > chmod 0664 /home/runner/work/inn/inn-install/db/history + # > makedbz: cannot chdir to /home/runner/work/inn/inn-install/db: Permission denied + + # - run: sudo -u news make install + + - run: systemctl status inn2 || true + - run: env + # - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db + # - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install + # - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + # - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + + # CAUTION: Running as root is dangerous. + - run: sudo INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + + + + + - run: pwd && ls -la + - run: ls -lR /etc 2>/dev/null | grep -E 'inn|news' + - run: ls -l /usr/local # No `news` directory + # - run: ls -lR /usr/local/news 2>/dev/null | grep -E 'inn|news' || true + # - run: find /etc -name inn.conf 2>/dev/null || true + - run: find /home -name inn.conf 2>/dev/null || true + # - run: find /usr/local/news -name inn.conf 2>/dev/null || true + - run: ls -la $RUNNER_WORKSPACE/inn/site || true + - run: cat $RUNNER_WORKSPACE/inn/site/inn.conf || true # Useful for debugging + # - run: cat /usr/local/news/etc/inn.conf || true # Useful for debugging + # - run: ls /etc/systemd/system || true + # - run: systemctl --help || true + # - run: systemctl list-units --all || true + # - run: systemctl list-units --type=service --all || true + - run: sudo systemctl enable inn2 || true + - run: sudo systemctl start inn2 || true + # - run: systemctl show inn2 || true + - run: systemctl status inn2 || true + # - run: /usr/lib/news/bin/rc.news || true + # Run all pynntp tests + - run: ls -la + - uses: actions/checkout@v4 + with: + repository: greenbender/pynntp + - uses: actions/setup-python@v5 + with: + python-version: '3.x' + - run: pip install --upgrade pip + - run: pip install pytest + - run: pip install --editable . + - run: pytest \ No newline at end of file From 588bc71fa266a59ef356563b996fb4152da3c579 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 16:56:19 +0200 Subject: [PATCH 2/7] sudo su news --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 0d601f64a..8c6a63a82 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -57,7 +57,7 @@ jobs: # - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start # CAUTION: Running as root is dangerous. - - run: sudo INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + - run: sudo su news ; INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start From d1d91a1277817a5e24ce9c4df5276b2365e7b211 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 17:03:05 +0200 Subject: [PATCH 3/7] sudo -u news --- .github/workflows/build.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 8c6a63a82..836517be1 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -41,7 +41,8 @@ jobs: - run: touch $RUNNER_WORKSPACE/inn-install/db/history - run: echo -e "local.general 1726983313 usenet\nlocal.test 1726983317 usenet" > $RUNNER_WORKSPACE/inn-install/db/active.times - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install - - run: sudo INN_HOSTNAME=inn.github-action make install + # - run: sudo INN_HOSTNAME=inn.github-action make install + - run: sudo -u news INN_HOSTNAME=inn.github-action make install # This fails on: # > touch /home/runner/work/inn/inn-install/db/history # > chmod 0664 /home/runner/work/inn/inn-install/db/history @@ -54,10 +55,10 @@ jobs: # - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db # - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install # - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start - # - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start # CAUTION: Running as root is dangerous. - - run: sudo su news ; INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + # - run: sudo su news ; INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start From 1d6d992f08034364329277330b5989dde374ad9e Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 19:26:43 +0200 Subject: [PATCH 4/7] sudo -u news --- .github/workflows/build.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 836517be1..a642179d8 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -42,7 +42,7 @@ jobs: - run: echo -e "local.general 1726983313 usenet\nlocal.test 1726983317 usenet" > $RUNNER_WORKSPACE/inn-install/db/active.times - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install # - run: sudo INN_HOSTNAME=inn.github-action make install - - run: sudo -u news INN_HOSTNAME=inn.github-action make install + - run: sudo INN_HOSTNAME=inn.github-action make install # This fails on: # > touch /home/runner/work/inn/inn-install/db/history # > chmod 0664 /home/runner/work/inn/inn-install/db/history @@ -55,6 +55,9 @@ jobs: # - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db # - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install # - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install + - run: ls -la $RUNNER_WORKSPACE/inn/site || true # Useful for debugging + - run: cat $RUNNER_WORKSPACE/inn/site/inn.conf || true # Useful for debugging - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start # CAUTION: Running as root is dangerous. From 0755fd6bb057455b335fbf7f2296e4ffad5b0589 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 19:35:35 +0200 Subject: [PATCH 5/7] sudo -u news --- .github/workflows/build.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a642179d8..0dc128523 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -30,17 +30,18 @@ jobs: steps: - run: env + - run: sudo usermod -aG news $USER - uses: actions/checkout@v4 - run: sudo -E ci/install - run: ./autogen - run: ./configure CC="${COMPILER:-gcc}" --prefix=$RUNNER_WORKSPACE/inn-install - --with-canlock --with-news-user=news --with-news-group=news --with-openssl + --with-canlock --with-news-user=$USER --with-news-group=news --with-openssl --with-perl --with-python --with-sasl --with-zlib - run: make - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db - run: touch $RUNNER_WORKSPACE/inn-install/db/history - run: echo -e "local.general 1726983313 usenet\nlocal.test 1726983317 usenet" > $RUNNER_WORKSPACE/inn-install/db/active.times - - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install + - run: sudo chown -R $USER:news $RUNNER_WORKSPACE/inn-install # - run: sudo INN_HOSTNAME=inn.github-action make install - run: sudo INN_HOSTNAME=inn.github-action make install # This fails on: @@ -55,10 +56,10 @@ jobs: # - run: mkdir -p $RUNNER_WORKSPACE/inn-install/db # - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install # - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start - - run: sudo chown -R news:news $RUNNER_WORKSPACE/inn-install + - run: sudo chown -R $USER:news $RUNNER_WORKSPACE/inn-install - run: ls -la $RUNNER_WORKSPACE/inn/site || true # Useful for debugging - run: cat $RUNNER_WORKSPACE/inn/site/inn.conf || true # Useful for debugging - - run: sudo -u news INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start # CAUTION: Running as root is dangerous. # - run: sudo su news ; INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start From 0f3bd38e2a8124ee01252d4d117868adbe0d260b Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 23:00:07 +0200 Subject: [PATCH 6/7] sudo -u news --- .github/workflows/build.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 0dc128523..b20f0667b 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -30,7 +30,9 @@ jobs: steps: - run: env + - run: echo $USER $(whoami) - run: sudo usermod -aG news $USER + - run: sudo usermod -aG news $(whoami) - uses: actions/checkout@v4 - run: sudo -E ci/install - run: ./autogen @@ -59,6 +61,9 @@ jobs: - run: sudo chown -R $USER:news $RUNNER_WORKSPACE/inn-install - run: ls -la $RUNNER_WORKSPACE/inn/site || true # Useful for debugging - run: cat $RUNNER_WORKSPACE/inn/site/inn.conf || true # Useful for debugging + - run: groups $(whoami) + - run: sudo chgrp news $RUNNER_WORKSPACE/inn-install/bin/rc.news + - run: sudo chmod g+x $RUNNER_WORKSPACE/inn-install/bin/rc.news - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start # CAUTION: Running as root is dangerous. From 1d07048c1871a01584119fb6902e625d4a24c9b2 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Oct 2024 23:37:32 +0200 Subject: [PATCH 7/7] sudo -u news --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b20f0667b..1b5c408f5 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -64,7 +64,7 @@ jobs: - run: groups $(whoami) - run: sudo chgrp news $RUNNER_WORKSPACE/inn-install/bin/rc.news - run: sudo chmod g+x $RUNNER_WORKSPACE/inn-install/bin/rc.news - - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start + - run: INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news # start # CAUTION: Running as root is dangerous. # - run: sudo su news ; INN_HOSTNAME=inn.github-action $RUNNER_WORKSPACE/inn-install/bin/rc.news start