TC in CIccTag:IsTypeCompressed() at IccProfLib/IccTagBasic.h#L1299

[xsscx]

Maintainer Repro

Wed Dec 31 07:11:59 PM UTC 2025

git rev-parse HEAD && git show --no-patch --oneline
b656e80
b656e80 (HEAD, origin/master, origin/HEAD, master) Add: Defense in Depth (#385)
uname -a
Linux 6.6.87.2-microsoft-standard-WSL2 #1 SMP PREEMPT_DYNAMIC Thu Jun 5 18:30:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Step 1. wget https://github.com/xsscx/Commodity-Injection-Signatures/raw/refs/heads/master/graphics/icc/ub-icDataBlockType-IccTagBasic_h-L1299.icc

Step 2. iccToXml ub-icDataBlockType-IccTagBasic_h-L1299.icc ub-icDataBlockType-IccTagBasic_h-L1299.xml

Expected Output

Build/Cmake/../../IccProfLib/IccTagBasic.h:1299:45: runtime error: load of value 16777216, which is not a valid value for type 'icDataBlockType'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Build/Cmake/../../IccProfLib/IccTagBasic.h:1299:45
XML successfully created

[ChrisCoxArt]

We read and write the field as 32 bits, but the enum only had a range of 16 bits.
An explicit size and end value for the enum should fix it.
Not a security issue, just overzealous reporting by UBSan.

And it would be a good idea to initialize the value when creating the class.

[xsscx]

Status

PR Ready

Sat Jan 3 11:42:50 PM UTC 2026

git rev-parse HEAD && git show --no-patch --oneline
812cd3f
812cd3f (HEAD -> issue-392, origin/issue-392) test binary bit instead of specific value

git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV/Build
git checkout issue-392
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j$(nproc)
cd ../Testing/
echo "=== Updating PATH ==="
for d in ../Build/Tools/*; do
[ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
done

wget https://github.com/xsscx/Commodity-Injection-Signatures/raw/refs/heads/master/graphics/icc/ub-icDataBlockType-IccTagBasic_h-L1299.icc

iccToXml ub-icDataBlockType-IccTagBasic_h-L1299.icc ub-icDataBlockType-IccTagBasic_h-L1299.xml

Expected Output

XML successfully created